Repository navigation
Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 1 | Time Clock - #1648
chefmatthaus-hub wants to merge 4 commits into
Conversation
cjyuan
left a comment
There was a problem hiding this comment.
Could you include a Changelist section in your PR description?
There was a problem hiding this comment.
Not all statements are terminated by a semicolon and spacing around { and '}` is not fully consistent.
Suggestion:
- Look up the benefits of using a code formatter.
- Install the Prettier extension for VS Code, then:
- Use VS Code's Format Document feature to format your code.
- Optionally, enable Format On Save and Format On Paste to keep your code consistently formatted.
Resource: Visual Studio Code - Formatting
Note: The formatter may not work correctly if your code contains syntax errors.
There was a problem hiding this comment.
Could you check whether the expected return values specified in the tests use a consistent format?
When a function's return values are not consistently formatted, it can lead to unintended side effects. For examples:
- When the formatted strings are displayed, they may not align nicely:
01:00 am
1:00 pm
12:00 am
01:00 pm
02:00pm
- When the formatted strings are compared in a program, they may produce unexpected results:
"1:00 pm" < "11:00 pm"evaluates tofalse"01:00 am" < "11:00 am"evaluates totrue
For this reason, it would be better to ensure that the function always returns values in a consistent format.
…or single-digit morning hours
|
Note: The Changelist section is missing a "Changelist" heading. |
Self checklist
Task code
CYF-1197
Fixed formatting issues in time conversion and update test assertions for single-digit morning hours