Skip to content

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 3| 1-implement-and-rewrite-tests -Final#1289

Open
Ayogit1 wants to merge 5 commits intoCodeYourFuture:mainfrom
Ayogit1:Sprint-3-implement-and-rewrite-tests-coursework
Open

Birmingham | ITP-Jan-26 | Ayodeji Ayorinde | Sprint 3| 1-implement-and-rewrite-tests -Final#1289
Ayogit1 wants to merge 5 commits intoCodeYourFuture:mainfrom
Ayogit1:Sprint-3-implement-and-rewrite-tests-coursework

Conversation

@Ayogit1
Copy link
Copy Markdown

@Ayogit1 Ayogit1 commented Apr 6, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

1-implement-and-rewrite-tests -Final

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 6, 2026
@Ayogit1 Ayogit1 mentioned this pull request Apr 6, 2026
Open
@LonMcGregor LonMcGregor added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Apr 7, 2026
@Ayogit1
Copy link
Copy Markdown
Author

Ayogit1 commented Apr 17, 2026

@LonMcGregor , Please what is wrong with this PR? I couldn't see any comments from you.

@Ayogit1 Ayogit1 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 17, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 18, 2026

Your previous Sprint-3 "Implement and Rewrite" PR already had a review. Please include the link of that PR here and describe how you addressed the comments.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Apr 19, 2026
@Ayogit1
Copy link
Copy Markdown
Author

Ayogit1 commented Apr 20, 2026

Not sure if you were referring to the PR below.
The said PR failed bot checks and that was the need for a final repeat. I consider the PR irrelevant and I plan too close it.
This current PR had all tasks completed.
Please let me know if I have missed something as time is against me.
Thanks.

#1288

@Ayogit1 Ayogit1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 20, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 20, 2026 •
edited
Loading

These are all your PRs (closed and open) you created in the Structuring and Testing Data module:
https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pulls?q=+author%3AAyogit1+

Those that has been reviewed have the the "Reviewed" or "Complete" labels.

@Ayogit1
Copy link
Copy Markdown
Author

Ayogit1 commented Apr 20, 2026

This PR is a continuation of the PR that has already had a review.

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 20, 2026

Would be helpful to share the link of that PR here.

@Ayogit1
Copy link
Copy Markdown
Author

Ayogit1 commented Apr 20, 2026

Link added:
#1215

cjyuan
cjyuan reviewed Apr 20, 2026
View reviewed changes
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 20, 2026
@Ayogit1 Ayogit1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 21, 2026
cjyuan
cjyuan reviewed Apr 21, 2026
View reviewed changes
Comment thread Sprint-3/1-implement-and-rewrite-tests/implement/3-get-card-value.js Outdated
Comment thread Sprint-3/1-implement-and-rewrite-tests/rewrite-tests-with-jest/1-get-angle-type.test.js Outdated
@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 21, 2026
@Ayogit1 Ayogit1 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 21, 2026
@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 21, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Apr 21, 2026

All good now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cjyuan cjyuan cjyuan left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Ayogit1 @cjyuan @LonMcGregor