Sheffield | 26-Jan-ITP | Daniel Aderibigbe | Sprint 3 | Implement and rewrite test done#1200
Closed
Dan2Clouted wants to merge 3 commits intoCodeYourFuture:mainfrom
Closed
Conversation
Dan2Clouted
added
the
Needs Review
cjyuan
reviewed
Mar 11, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Function implementations look good.
This exercise has a second part "2 Rewrite tests with Jest" ==> three more files to be updated.
cjyuan
added
Reviewed
Author
|
The have been updated now. Thanks in Advance |
Dan2Clouted
added
the
Needs Review
cjyuan
reviewed
Mar 11, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Just a few suggestions.
I will mark this as Complete first.
Comment on lines
+43
to
+46
| test(`should return "Invalid angle" when angle < 0 or angle >= 360`, () => { | ||
| expect(getAngleType(-1)).toEqual("Invalid angle"); | ||
| expect(getAngleType(360)).toEqual("Invalid angle"); | ||
| }); |
Contributor
There was a problem hiding this comment.
It's good that you tested one of the boundary cases. You could consider testing the other one.
Comment on lines
+21
to
+24
| test(`should return true when the absolute value of the numerator is smaller than the absolute value of the denominator`, () => { | ||
| expect(isProperFraction(-1, 2)).toEqual(true); | ||
| expect(isProperFraction(1, -2)).toEqual(true); | ||
| }); |
Contributor
There was a problem hiding this comment.
This category probably cover the positive case, and you can use notations like | ... | or abs(...) in the description to make it more concise.
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed all the exercisces required.