Sheffield | 26-ITP-jan | Richard Frimpong | Sprint 3 | Practice TDD

[Richiealx]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

This PR completes the Sprint 3 Practice TDD coursework.

Implemented functionality

• Implemented getOrdinalNumber following TDD principles.
• Added logic to correctly return ordinal suffixes:
  • st for numbers ending in 1 (except 11)
  • nd for numbers ending in 2 (except 12)
  • rd for numbers ending in 3 (except 13)
  • th for all other numbers.

Tests

Jest tests were written and run to verify the implementation.

Tests executed using:

• npx jest Sprint-3/2-practice-tdd
• All tests pass successfully

[cjyuan]

There are 6 files to be modified in this exercise. Currently there are only 2 modified files on this branch.

[Richiealx]

There are 6 files to be modified in this exercise. Currently there are only 2 modified files on this branch.

Hi @cjyuan,

Thanks for the feedback.

I have now completed the Sprint-3/2-practice-tdd task across all 6 files in the folder:

• count.js
• count.test.js
• repeat-str.js
• repeat-str.test.js
• get-ordinal-number.js
• get-ordinal-number.test.js

I ran:

npx jest Sprint-3/2-practice-tdd

and all tests passed.

I pushed the fixes to the same branch.

[cjyuan]

Looks good. Well done.

[cjyuan]

These are also some good cases:
- A case to show that the match is case sensitive
- A case to show that the function is expected to work also for non-alphabets

[illicitonion]

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.