West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 3 | TDD#1134
Closed
alizada-dev wants to merge 11 commits intoCodeYourFuture:mainfrom
Closed
West Midlands | 26-Jan-ITP | Fida H Ali Zada | Sprint 3 | TDD#1134alizada-dev wants to merge 11 commits intoCodeYourFuture:mainfrom
alizada-dev wants to merge 11 commits intoCodeYourFuture:mainfrom
Conversation
alizada-dev
added
the
Needs Review
cjyuan
reviewed
Mar 10, 2026
Comment on lines
+25
to
+30
| test(`should return 0 for no occurances of 'char' in 'str'`, () => { | ||
| const str = "code your future"; | ||
| const char = "x"; | ||
| const count = countChar(str, char); | ||
| expect(count).toEqual(0); | ||
| }) |
Contributor
There was a problem hiding this comment.
-
Could consider testing more samples.
-
Could consider testing these cases:
- A case to show that the match is case sensitive
- A case to show that the function is expected to work also for non-alphabets
Author
There was a problem hiding this comment.
Thank you, sir, for the review. I fixed all the suggested changes.
| if (count >= 0) { | ||
| return str.repeat(count); | ||
| } else { | ||
| throw new Error(""); |
Contributor
There was a problem hiding this comment.
Why not include an informative error message to inform the caller what the error is?
| test("should throw an error", () => { | ||
| const str = "responsibility"; | ||
| const count = -5; | ||
| // const repeatedStr = repeatStr(str, count); |
Contributor
There was a problem hiding this comment.
Why keep the code as comment on line 48?
cjyuan
added
Reviewed
alizada-dev
added
Needs Review
cjyuan
reviewed
Mar 10, 2026
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Changes look good. Well done.
Comment on lines
+32
to
+35
| test(`in case sensitive case, should also return the number of character in the string`, () => { | ||
| expect(countChar("Code Your Future!", "Y")).toEqual(1); | ||
| }); | ||
|
|
Contributor
There was a problem hiding this comment.
Could include a lower case y in the input to demonstrate and ensure the match is indeed case-sensitive.
Comment on lines
+44
to
+46
| test(`should return the count for unusual characters`, () => { | ||
| expect(countChar("code& $future £your", "$")).toEqual(1) | ||
| }) No newline at end of file |
Contributor
There was a problem hiding this comment.
I think there is a more common name that describes characters that are neither alphabets nor digits, than "unusual characters".
cjyuan
added
Complete
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Wrote tests before the code that will make them pass.