Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359
Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359Enice-Codes wants to merge 6 commits into
Conversation
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
1 similar comment
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
No new commits were pushed to this PR branch on GitHub yet. If you have made changes and commits on your computer, you would need to also push (sync) them to GitHub. You may also want to check if the changes were made on the correct branch. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
It seems you had committed changes intended for your Form-Controls PR on the wrong branch. Since your most recent commit c5c43b5 introduced these two files in the Form-Controls folder you can fix the problem by removing them and then make a new commit. |
c5c43b5 to
8a70e00
Compare
|
Good job in fixing the branch. Can you address all the comments in #1359 (review) ? I don't see any change yet. |
cjyuan
left a comment
There was a problem hiding this comment.
-
According to https://validator.w3.org/, there are errors in your code. Can you fix them?
-
One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).
-
Image in article 1 appears as a corrupted image icon.
| src="images/shopping wireframe.jpg" | ||
| alt="picture of a shopping cart" | ||
| /> | ||
| <h2>What is the purpose of a wireframe?</h2> |
There was a problem hiding this comment.
Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images fail to load, giving users essential context about the content or function of the image.
Assuming the images are placeholders for actual images related to the articles. Can you give a more descriptive alt value to all images?
5a5779c to
0582aff
Compare
|
The changed files in this PR don't match what is expected for this task. Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints. Please review the changed files tab at the top of the page, we are only expecting changes in this directory: If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
|
One of your earlier commits reintroduced modified files in the Form-Controls folder. That's why the Validation Bot is complaining. If you find fixing the branch troublesome, you can create a new branch for the Wireframe exercise and work on that branch. Note: Before creating any new branch, you should update your Currently,
|


Learners, PR Template
Self checklist
Changelist
Questions
I do not have any questions