Skip to content

Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359

Open
Enice-Codes wants to merge 6 commits into
CodeYourFuture:mainfrom
Enice-Codes:Feature/Wireframe
Open

Cape Town | May-ITP-26 | Enice Mutanda | Sprint 2 | WireFrame#1359
Enice-Codes wants to merge 6 commits into
CodeYourFuture:mainfrom
Enice-Codes:Feature/Wireframe

Conversation

@Enice-Codes

@Enice-Codes Enice-Codes commented May 27, 2026

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Changed image
  • fixed footer positioning
  • used CSS Grid to style layout
  • Added semantic HTML structure
  • Improved layout

Questions

I do not have any questions

@netlify

netlify Bot commented May 27, 2026

Copy link
Copy Markdown

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 0582aff
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2b48b0abf1050008edb78f
😎 Deploy Preview https://deploy-preview-1359--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 90 (🔴 down 10 from production)
Accessibility: 93 (🔴 down 7 from production)
Best Practices: 100 (no change from production)
SEO: 83 (🔴 down 3 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added 🏕 Priority Mandatory This work is expected 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 27, 2026
@github-actions

This comment has been minimized.

2 similar comments
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@Enice-Codes Enice-Codes reopened this May 27, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 27, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 28, 2026
@github-actions

This comment has been minimized.

1 similar comment
@github-actions

This comment has been minimized.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels May 30, 2026
@github-actions

This comment has been minimized.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@cjyuan

cjyuan commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

No new commits were pushed to this PR branch on GitHub yet.

If you have made changes and commits on your computer, you would need to also push (sync) them to GitHub.

You may also want to check if the changes were made on the correct branch.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 3, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 4, 2026
@cjyuan

cjyuan commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

It seems you had committed changes intended for your Form-Controls PR on the wrong branch.

Since your most recent commit c5c43b5 introduced these two files in the Form-Controls folder
image

you can fix the problem by removing them and then make a new commit.

@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 5, 2026
@cjyuan

cjyuan commented Jun 6, 2026

Copy link
Copy Markdown
Contributor

Good job in fixing the branch.

Can you address all the comments in #1359 (review) ? I don't see any change yet.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 6, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 9, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • According to https://validator.w3.org/, there are errors in your code. Can you fix them?

  • One of the acceptance criteria, "The page footer is fixed to the bottom of the viewport", has not yet been satisfied. Can you make the necessary change? (Suggestion: Ask AI what that requirement means).

  • Image in article 1 appears as a corrupted image icon.

image

Comment thread Wireframe/index.html Outdated
Comment on lines +41 to +44
src="images/shopping wireframe.jpg"
alt="picture of a shopping cart"
/>
<h2>What is the purpose of a wireframe?</h2>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Providing meaningful alt text is important because it ensures images are accessible to people using screen readers and also helps when images fail to load, giving users essential context about the content or function of the image.

Assuming the images are placeholders for actual images related to the articles. Can you give a more descriptive alt value to all images?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 10, 2026
@Enice-Codes Enice-Codes added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026
@github-actions

Copy link
Copy Markdown

The changed files in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the changed files tab at the top of the page, we are only expecting changes in this directory: ^Wireframe/

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 11, 2026
@cjyuan

cjyuan commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

One of your earlier commits reintroduced modified files in the Form-Controls folder. That's why the Validation Bot is complaining. If you find fixing the branch troublesome, you can create a new branch for the Wireframe exercise and work on that branch.

Note: Before creating any new branch, you should update your main using the "Sync fork" button on GitHub first, then sync your local branch.


Currently,

  • There are syntax errors in your HTML code
  • The footer is not centered and fixed at the bottom of the viewport

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Module-Onboarding The name of the module. 🏕 Priority Mandatory This work is expected Reviewed Volunteer to add when completing a review with trainee action still to take. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants