Glasgow| 26-ITP-Jan|Fattouma Ouannassi| Sprint 2 | Form Controls #1000
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
<!-- You must title your PR like this: Region | Cohort | FirstName LastName | Sprint | Assignment Title For example, London | 25-ITP-May | Carol Owen | Sprint 1 | Alarm Clock Fill in the template below - remove any sections that don't apply. Complete the self checklist - replace each empty box in the checklist [ ] with a [x]. Add the label "Needs Review" and you will get review. Respond to volunteer reviews until the volunteer marks it as "Complete". --> ## Learners, PR Template Self checklist - [x] I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title - [x] My changes meet the requirements of the task - [x] I have tested my changes - [x] My changes follow the [style guide](https://curriculum.codeyourfuture.io/guides/reviewing/style-guide/) ## Changelist This PR includes modifications to the HTML file to create an order form for customers to order T-Shirts. [✓] My form is semantic html. [✓] All inputs have associated labels. [✓] My Lighthouse Accessibility score is 100. [✓] I require a valid name. I have defined a valid name as a text string of two characters or more. [✓] I require a valid email. [✓] I require one colour from a defined set of 3 colours. [✓] I require one size from a defined set of 6 sizes. ## Questions /
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
FAprogrammerO
added
📅 Sprint 1
A-O-Emmanuel
added
Review in progress
| type="text" | ||
| id="name" | ||
| title="Name must contain only letters and spaces"><br><br> | ||
|
|
There was a problem hiding this comment.
can you come up with a better way to check if customer name is a valid name?
| id="email" | ||
| name="email" | ||
| required> | ||
| <br><br> |
There was a problem hiding this comment.
also come up with a better way to check if Email address is a valid email address.
| <label for="colour">T-Shirt Colour:</label> | ||
| <br> | ||
| <select id="colour" name="colour"required> | ||
| <option value="select a colour">Select a colour</option> |
There was a problem hiding this comment.
select a colour is not supposed to be part of the option value
A-O-Emmanuel
left a comment
A-O-Emmanuel
left a comment
There was a problem hiding this comment.
This is a good attempt, please look at the comments and work on them, good job!
A-O-Emmanuel
added
Reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
This PR includes modifications to the HTML file to create an order form for customers to order T-Shirts.
[✓] My form is semantic html.
[✓] All inputs have associated labels.
[✓] My Lighthouse Accessibility score is 100.
[✓] I require a valid name. I have defined a valid name as a text string of two characters or more.
[✓] I require a valid email.
[✓] I require one colour from a defined set of 3 colours.
[✓] I require one size from a defined set of 6 sizes.
Questions
/