West Midlands | 25-SDC-July | Gabriel Deng | Sprint 1 | New feature: Rebloom #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gai93003
added
📅 Sprint 1
gai93003
changed the title
Member
illicitonion
left a comment
illicitonion
left a comment
There was a problem hiding this comment.
This generally looks great! Just a couple of small comments to consider :)
|
|
||
|
|
||
| @jwt_required() | ||
| @jwt_required() |
Member
There was a problem hiding this comment.
Was the double @jwt_required intentional?
| if not original_bloom: | ||
| return make_response(("Bloom not found", 404)) | ||
|
|
||
| # Create a new bloom with the same content, linking to original |
Member
There was a problem hiding this comment.
Interesting - should reblooms copy the content?
Imagine if added bloom editing in the future - would we want to automatically edit the rebloom? Or keep the copied value?
illicitonion
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.