Skip to content

ZA | 25-SDC-JULY | Luke Manyamazi | Sprint 1 | Hashtag link doesn't work correctly #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Luke-Manyamazi wants to merge 2 commits into
base: main
Choose a base branch
from
Open

ZA | 25-SDC-JULY | Luke Manyamazi | Sprint 1 | Hashtag link doesn't work correctly #53

Luke-Manyamazi wants to merge 2 commits into from

Conversation

@Luke-Manyamazi
Copy link

@Luke-Manyamazi Luke-Manyamazi commented Nov 11, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Updated _formatHashtags() regex from /\B#[^#]+/g to /(^|\s)#[^#\s]+/g
  • Fixed issue where hashtags following punctuation (e.g. "Let's get some #SwizBiz") were not being linked
  • Ensured hashtags at the start of text (e.g. "#Welcome") are now linked correctly
  • Preserved spacing before hashtags when rendering clickable links
  • Improved reliability of hashtag detection across all bloom posts

Questions

None

@Luke-Manyamazi Luke-Manyamazi added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Legacy-Code The name of the module. labels Nov 11, 2025
illicitonion
illicitonion reviewed Jan 20, 2026
View reviewed changes
Copy link
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solid, and a good explanation in the description of your choices, well done!

@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Legacy-Code The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Purple Forest Kanban
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Luke-Manyamazi @illicitonion