Skip to content

ZA | 25-SDC-JULY | Luke Manyamazi | Sprint 1 | Hashtag Slowing Down My Browser#189

Open
Luke-Manyamazi wants to merge 2 commits intoCodeYourFuture:mainfrom
Luke-Manyamazi:feature-Hashtag-slowing-down-my-browser
Open

ZA | 25-SDC-JULY | Luke Manyamazi | Sprint 1 | Hashtag Slowing Down My Browser#189
Luke-Manyamazi wants to merge 2 commits intoCodeYourFuture:mainfrom
Luke-Manyamazi:feature-Hashtag-slowing-down-my-browser

Conversation

@Luke-Manyamazi
Copy link
Copy Markdown

@Luke-Manyamazi Luke-Manyamazi commented Apr 21, 2026 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

  • Fixed hashtag link generation to prevent malformed URLs caused by trailing spaces
  • Updated hashtag timeline rendering so hashtag pages load blooms correctly without flashing blank

Questions

None

@Luke-Manyamazi Luke-Manyamazi added 📅 Sprint 1 Assigned during Sprint 1 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Legacy-Code The name of the module. labels Apr 21, 2026
illicitonion
illicitonion reviewed Apr 22, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@illicitonion illicitonion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR appears to have a lot of different changes in it - can you split those changes out into separate PRs that can be independently reviewed?

@illicitonion illicitonion added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Apr 22, 2026
@Luke-Manyamazi
Copy link
Copy Markdown
Author

Luke-Manyamazi commented Apr 23, 2026

Hi Daniel - please check I have removed the unwanted changes and I believe, am left with the hashtag

@illicitonion illicitonion added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Apr 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@illicitonion illicitonion illicitonion left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Legacy-Code The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

Purple Forest Kanban
Status: Backlog

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Luke-Manyamazi @illicitonion