Skip to content

Cape Town | 26-ITP-Sep | Raees Stevens | Sprint 3 | Coursework/sprint 3 - #1643

Open
RaeesStevens wants to merge 1 commit into
CodeYourFuture:mainfrom
RaeesStevens:coursework/sprint-3
Open

RaeesStevens wants to merge 1 commit into
CodeYourFuture:mainfrom
RaeesStevens:coursework/sprint-3

Conversation

@RaeesStevens

@RaeesStevens RaeesStevens commented Oct 8, 2026 •

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1053

Changelist

Completed mandatory Sprint-3 Coursework

@netlify

netlify Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit a3ef048
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ac7233489fc410009ccd1cb
😎 Deploy Preview https://deploy-preview-1643--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@RaeesStevens RaeesStevens added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 8, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Comment on lines 22 to 25
function capitalise(str) {
let str = `${str[0].toUpperCase()}${str.slice(1)}`;
str = `${str[0].toUpperCase()}${str.slice(1)}`;
return str;
}

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The alternatives of reassigning the function parameters are:

  • Use a separate const variable
  • Return the expression directly

Suggestion: Use AI to explore the trade-off of these approaches.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants