Cape Town | sep-2026-ITP | Edward kganyago | Sprint 3 | CYF-1053 by edwardkganyago45-source · Pull Request #1633 · CodeYourFuture/Module-JavaScript-Fundamentals

edwardkganyago45-source · 2026-09-30T20:46:49Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

Completed Sprint 3 course work

netlify · 2026-09-30T20:46:54Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`dbc121d`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6abd753b9b35b900089486e9
😎 Deploy Preview	https://deploy-preview-1633--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

github-actions · 2026-09-30T20:47:04Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-09-30T20:47:37Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-09-30T20:47:39Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

iscmiguelsamaniego

Fantastic work overall! You have shown brilliant progress in mastering core JavaScript fundamentals:

working with variables and assignment, writing and invoking reusable functions, using template literals, handling string methods, and working through time and math calculations.

Your dedication to debugging errors step by step is really paying off. Keep up the amazing work!

iscmiguelsamaniego · 2026-10-01T03:53:11Z

"Nice work exploring default parameters!
Quick question: When you run console.log(\hello${greet("12:00")} how are you?), what gets printed in the console and why does undefined show up in the middle of the string?"

iscmiguelsamaniego · 2026-10-01T03:54:06Z

Great fix using string1! Just a quick note: str is a valid variable name, but the error happened because it was already declared as a parameter.

Quick question: Do you need to store the result in a new variable, or could you return the template literal directly?

iscmiguelsamaniego · 2026-10-01T03:54:34Z

Good job fixing the function body!

Quick question: When you run console.log(convertToPercentage);, what gets printed in the terminal, and how do you need to write that console.log to see the percentage result?

iscmiguelsamaniego · 2026-10-01T03:55:10Z

"Great job fixing the parameter name!

Quick question: How would you test this function by calling it and logging the result to the console?"

iscmiguelsamaniego · 2026-10-01T03:55:55Z

"Great job fixing that to use return instead of console.log!
Quick question: Do the extra parentheses around (a * b) change how the code behaves, or are they optional?"

iscmiguelsamaniego · 2026-10-01T03:57:08Z

Take a close look at where num comes from inside getLastDigit.

Quick question: How can you update the function definition so it accepts an argument and uses the number passed to it instead of the global num = 103?

iscmiguelsamaniego · 2026-10-01T03:58:14Z

Let's break down the formula step by step:

Squaring the height: In JavaScript, the ^ symbol is a bitwise operator, not a power exponent. To square a number, you can use height * height or height ** 2.

The operation: The instructions state to divide the weight by the squared height, rather than multiplying.

Decimal places: To format the result to 1 decimal place as requested, you can use the .toFixed(1) method.

What would the code look like if you combine division, squaring, and .toFixed(1)?

iscmiguelsamaniego · 2026-10-01T03:59:59Z

"Great job! Using regular expressions (/ /g) with replace and toUpperCase is a very clean solution.
Quick question: What happens if there are multiple spaces between words, like "hello there", and how could we handle that?"

iscmiguelsamaniego · 2026-10-01T04:00:34Z

"Great job turning this into a working, reusable function and testing it with "900p"!
Quick question: Look at the first line (let penceString = string;). Is that extra variable necessary, or could you use the function parameter directly?"

iscmiguelsamaniego · 2026-10-01T04:01:21Z

"Almost there! Let's check a couple of small things:

Syntax check: Look closely right after the pad function—it's missing a closing curly brace } before formatTimeDisplay starts, which will cause a syntax error.

Question (d): When pad is called for the last time (for the seconds), the value assigned to num is 1 (since 61 % 60 = 1).

Question (e): The return value of that specific call to pad(1) is "01". (Note: "00:01:01" is the final result of the whole formatTimeDisplay function, whereas pad only returns the formatted piece for that single call).

Try adding the missing closing brace and running your console.log(formatTimeDisplay(61))—what does it output in the terminal?"

github-actions · 2026-10-03T11:23:32Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T11:24:20Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T11:25:18Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T11:25:30Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T11:30:04Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T11:40:21Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T11:41:53Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T12:06:44Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

github-actions · 2026-10-03T12:07:53Z

The files changed in this PR don't match what is expected for this task.

Please check that you committed the right files for the task, and that there are no accidentally committed files from other sprints.

Please review the 'files changed' tab at the top of the page.

Here is an example of a file that has been changed on this branch but shouldn't be: Sprint-2/1-key-exercises/4-random.js

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

edwardkganyago45-source added 11 commits September 29, 2026 16:55

Completed first error

e49f9cb

Completed error 1

4f07ca0

completed error 2

6700cbc

fixed mandatory debug 0

00e61a2

debug 0 done

90d82d7

added comment

494f9cb

completed implimentation 1

98a2d9c

Fixed BMI

081abeb

Finished cases JS

4b5f054

finished mandatory implement

0ada783

finished sprint 3

dbc121d

edwardkganyago45-source added 📅 Sprint 3 Assigned during Sprint 3 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 30, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 30, 2026

iscmiguelsamaniego approved these changes Oct 1, 2026

View reviewed changes

edwardkganyago45-source added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

edwardkganyago45-source added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 3, 2026

Uh oh!

Conversation

edwardkganyago45-source commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Changelist

Uh oh!

netlify Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

iscmiguelsamaniego left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

github-actions Bot commented Oct 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

edwardkganyago45-source commented Sep 30, 2026 •

edited

Loading

netlify Bot commented Sep 30, 2026 •

edited

Loading