London | 26-ITP-Sep | Mahir Shah | Sprint 3 | Sprint 3 Coursework by MahirShah300 · Pull Request #1625 · CodeYourFuture/Module-JavaScript-Fundamentals

MahirShah300 · 2026-09-28T22:02:40Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Task code

CYF-1053

Changelist

Answered the questions, fixed all bugs

…riable with same name

…outside function

…meter and giving default value

…so properly returned

…um parameter to function getLastDigit

netlify · 2026-09-28T22:02:47Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`9b453d8`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ac0fd2b9335f200086bcf99
😎 Deploy Preview	https://deploy-preview-1625--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports
🤖 Make changes	Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

madhuranakate · 2026-09-30T14:16:57Z

 // =============> write your new code here
+
+function capitalise(str) {
+  str = `${str[0].toUpperCase()}${str.slice(1)}`;


A general rule of thumb is - if you overwrite the value of parameter, it could cause bugs down the code as the original value is lost.

could you perhaps create a local variable instead and return that ?

I made a change to use a variable capitaliseStr

Good. str keeps its first value now.

madhuranakate · 2026-09-30T14:23:02Z

 // =============> write your new code here

-
+function square(num = 3) {


this will default the number to 3 if not passed (which is not what the requirement was). Instead, Can you try calling the square with different numbers and see the output

I removed the default parameter, it squares the number when calling it with different numbers

Good. square works for any number now.

madhuranakate · 2026-09-30T14:29:51Z

 // Use the MDN string documentation to help you find a solution
 // This might help https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/String/toUpperCase
+function toUpperSnakeCase(inputString) {
+  return inputString.toUpperCase().replaceAll(" ", "_");


why was the replaceAll used ? does this print exactly what is expected or does it add some additional strings which were not part of input string ?

replaceAll goes through a string and removes all cases of the first input, and replaces it with the second input. It prints what is expected, and the only thing added are _ in places of " ". If there's any unexpected whitespace " " after a string, they would replaced with _

Clear answer, thanks.

madhuranakate · 2026-09-30T14:34:28Z

+}
 function formatAs12HourClock(time) {
-  const hours = Number(time.slice(0, 2));
+  if (


good effort. could you think of other scenarios you might have missed ?

what happens when you pass empty strings - formatAs12HourClock(" :30")

what happens when you pass nothing - formatAs12HourClock()

what happens when you pass without semicolon - formatAs12HourClock(1230)

1.Empty strings are caught and show "Not a valid time"
2. This would cause errors. I fixed it by using default parameter ""
3. Without a semicolon is also caught. However if the input is not a string it would cause errors, which I fixed by checking if the input is type string

This is the stretch part, so it does not block Complete. But one check: what does formatAs12HourClock(" :30") give now? I get "12:30 am".

It does give "12:30 am". This is because there is validation on whitespace in the input string. I have added it now

Fixed now. Good.

madhuranakate · 2026-09-30T14:36:27Z

+    isNaN(minutes) ||
+    hours >= 24 ||
+    hours < 0 ||
+    minutes >= 60 ||


you are not checking if he hours and minutes are integers eg. "12:30.5" would pass your tests

"12:30.5" actually doesn't pass the tests because of my checks for only one "." and one ":", but I added a check to make sure the numbers are integers

…r integers

abdishakoor-dev

Thanks for the changes. Your answers are clear and correct. In time-format.js e) you explain each step of the while loop. That is very good.

One thing before I can mark this Complete:

3-to-pounds.js: see my comment on line 24.

Add the Needs Review label again once you've pushed.

abdishakoor-dev · 2026-10-01T18:24:46Z

+    .substring(paddedPenceNumberString.length - 2)
+    .padEnd(2, "0");
+
+  console.log(`£${pounds}.${pence}`);


Your function prints the price, but it does not give it back. What does toPounds("399p") return?

You explained this yourself in 2-mandatory-debug/0.js: a function that only uses console.log gives back undefined.

Say another part of a program needs the price. For example, it wants to add it to a sentence. Can it get the price from toPounds now? What would you change?

Not currently. I have changed the console.log to return £${pounds}.${pence} instead

Your function returns the price now, which is right. And you call it a few times with different values. But how do you know it works each time? Line 6 says to call it "to check it works for different inputs".

There are a few ways to do this:

Wrap each function call in lines 27-31 in console.log, so the returned value is printed in the terminal: console.log(toPounds("10p"));

Or use console.assert, like you did in format-time.js, to compare each result with the price you expect.

abdishakoor-dev

Thanks. toPounds gives the price back now, which is the important part.

Two small things before I can mark this Complete, both in 3-to-pounds.js:

Line 24: see my reply there.
The file fails Prettier since your last change. Open it, right click, choose Format Document, save, and push.

Add the Needs Review label again once you've pushed.

MahirShah300 added 12 commits September 23, 2026 17:13

Predict and explain errors. Fix by removing let so not to make new va…

38c5f48

…riable with same name

Predict and explain errors. Fix by removing line and making variable …

b862d6d

…outside function

Predict and explain error. Fix by giving adding variable name to para…

d311b62

…meter and giving default value

Create function to calculate BMI

d9257c2

Create function to return upper snake case string

8dcfe07

Take previous code and made into function toPounds

9ff0a0b

Predict and explaind bug. Fix by changing function to return a * b

ebffeae

Predict and explain bug. Fix by moving a + b before ; in return line …

818cc32

…so properly returned

Predict and explain bug. Fix by removing num declaration and adding n…

b0260ef

…um parameter to function getLastDigit

Answer questions

f54452f

Fix bugs, extend code to catch different inputs. Write tests

38825cb

Fix formatting

ab74a01

MahirShah300 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 28, 2026

This comment has been minimized.

Sign in to view

MahirShah300 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 30, 2026

madhuranakate added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 30, 2026

madhuranakate reviewed Sep 30, 2026

View reviewed changes

madhuranakate added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 30, 2026

MahirShah300 added 3 commits October 1, 2026 14:43

Add variable capitaliseStr instead of changing original string

d27c7d8

Remove default parameter from square function

508e466

Made fix to catch cases of empty strings, non-string inputs, check fo…

92cdff7

…r integers

MahirShah300 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 1, 2026

abdishakoor-dev reviewed Oct 1, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 1, 2026

MahirShah300 added 2 commits October 2, 2026 17:56

Fix toPounds function to return string template

ad83dc0

Add validation check for whitespace in input string

d643752

MahirShah300 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 2, 2026

abdishakoor-dev reviewed Oct 3, 2026

View reviewed changes

abdishakoor-dev added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2026

Add assertions for testing. Fix formatting

9b453d8

MahirShah300 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 3, 2026

		// =============> write your new code here


		function square(num = 3) {

Uh oh!

Conversation

MahirShah300 commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Task code

Changelist

Uh oh!

netlify Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

This comment has been minimized.

This comment has been minimized.

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

abdishakoor-dev left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MahirShah300 commented Sep 28, 2026 •

edited

Loading

netlify Bot commented Sep 28, 2026 •

edited

Loading