Skip to content

Manchester | 26-ITP-Sep | Ahmed Elmahmoudi | Sprint 1 | Form controls - #1506

Open
Alaterry8 wants to merge 11 commits into
CodeYourFuture:mainfrom
Alaterry8:feature/form-controls
Open

Manchester | 26-ITP-Sep | Ahmed Elmahmoudi | Sprint 1 | Form controls#1506
Alaterry8 wants to merge 11 commits into
CodeYourFuture:mainfrom
Alaterry8:feature/form-controls

Conversation

@Alaterry8

@Alaterry8 Alaterry8 commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task ID: CYF-1004

Changelist

  • Added a name field
  • Added an email field
  • Added a colour selector
  • Added a size option selector
  • Tested accessibility on lighthouse using Dev tools

I agree to follow the code of conduct for this organisation.

@netlify

netlify Bot commented Sep 12, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c7d82b4
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6ac4d9db5c0c490008abc04a
😎 Deploy Preview https://deploy-preview-1506--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@Alaterry8 Alaterry8 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Alaterry8 Alaterry8 changed the title Manchester | 26-ITP-Sep | Ahmed Elmahmoudi | Sprint 1 | Form controls Manchester | 26-ITP-Sep | Ahmed Elmahmoudi | Sprint 1 | Form controls/CYF-0000 Sep 12, 2026
@github-actions

This comment has been minimized.

Sign in to view
@Alaterry8 Alaterry8 changed the title Manchester | 26-ITP-Sep | Ahmed Elmahmoudi | Sprint 1 | Form controls/CYF-0000 Manchester | 26-ITP-Sep | Ahmed Elmahmoudi | Sprint 1 | Form controls Sep 12, 2026
@Alaterry8 Alaterry8 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Sep 13, 2026
@Liam310 Liam310 added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Sep 14, 2026
Liam310
Liam310 reviewed Sep 15, 2026
View reviewed changes
Comment thread Form-Controls/index.html Outdated
Liam310
Liam310 reviewed Sep 15, 2026
View reviewed changes
Comment thread Form-Controls/index.html Outdated
Liam310
Liam310 reviewed Sep 15, 2026
View reviewed changes
Comment thread Form-Controls/index.html
@Liam310

Liam310 commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

Hey @Alaterry8! You've showcased a good understanding of some appropriate choices for form elements here along with a good start with validating the inputs. As it stands, there are still a couple of inputs that are considered valid when they shouldn't be. Have a read of comments and see what you think!

@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. labels Sep 15, 2026
@Alaterry8 Alaterry8 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 3, 2026
@Alaterry8

Alaterry8 commented Oct 3, 2026

Copy link
Copy Markdown
Author

Hey @Liam310, apologies for the delay, just got around to adding the last bits, do let me know if any further changes are needed. Thanks!

Liam310
Liam310 reviewed Oct 6, 2026
View reviewed changes
Comment thread Form-Controls/index.html Outdated
Comment on lines +21 to +22
minlength="2"
pattern="[A-Za-z]+"

@Liam310 Liam310 Oct 6, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pattern is the correct attribute to use here, but this is not the right pattern. Have a read of the instructions again and you'll find what you're looking for!

@Liam310 Liam310 added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 6, 2026
@Liam310

Liam310 commented Oct 6, 2026

Copy link
Copy Markdown
Contributor

@Alaterry8 Just a small change to make!

@Alaterry8 Alaterry8 added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 6, 2026
@Liam310 Liam310 added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 8, 2026
@Liam310

Liam310 commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

All good 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Liam310 Liam310 Liam310 left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Alaterry8 @Liam310