London | 25-ITP-Sep | Mariia Serhiienko | Sprint 3 | Alarm Clock #903
+84
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Konvaly
added
the
Needs Review
wheresdiasd
added
Review in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self checklist
This PR implements the core alarm clock behavior: clicking Set Alarm reads the value from the input and immediately updates the header to Time Remaining: MM:SS, then counts down once per second. When the timer reaches 00:00, the app triggers the alarm sound via playAlarm() and changes the page background to another colour (now its cerulean) to visually indicate the alarm has finished. It also adds input validation so the alarm can only be set using a positive whole number, preventing invalid countdowns.