generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 193
West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 3 | Slideshow #884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
MohammedNaru
wants to merge
2
commits into
CodeYourFuture:main
Choose a base branch
from
MohammedNaru:Sprint-3-Slideshow
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,12 @@ | ||
| <!DOCTYPE html> | ||
| <html lang="en"> | ||
| <head> | ||
| <head> | ||
| <meta charset="UTF-8" /> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0" /> | ||
| <title>Title here</title> | ||
| <title>Image carousel</title> | ||
| <link rel="stylesheet" href="style.css" /> | ||
| <script defer src="slideshow.js"></script> | ||
| </head> | ||
| <body> | ||
| <img id="carousel-img" src="./assets/cute-cat-a.png" alt="cat-pic" /> | ||
| <button type="button" id="backward-btn">Backwards</button> | ||
| <button type="button" id="forward-btn">Forward</button> | ||
| </body> | ||
| </html> | ||
| <div id="button-bar"/> | ||
| </body> | ||
| </html> |
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great work, but you might want to recheck how the auto-mode buttons get enabled and disabled during different actions. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,103 @@ | ||
| const images = [ | ||
| "./assets/cute-cat-a.png", | ||
| "./assets/cute-cat-b.jpg", | ||
| "./assets/cute-cat-c.jpg", | ||
| "./assets/cute-cat-a.png", | ||
| "./assets/cute-cat-b.jpg", | ||
| "./assets/cute-cat-c.jpg", | ||
| ]; | ||
|
|
||
| const buttons = [ | ||
| { | ||
| type: "button", | ||
| id: "auto-backward", | ||
| text: "Auto Back", | ||
| }, | ||
| { | ||
| type: "button", | ||
| id: "backward-btn", // updated to match test | ||
| text: "Back", | ||
| }, | ||
| { | ||
| type: "button", | ||
| id: "stop", | ||
| text: "Stop", | ||
| }, | ||
| { | ||
| type: "button", | ||
| id: "forward-btn", // updated to match test | ||
| text: "Forward", | ||
| }, | ||
| { | ||
| type: "button", | ||
| id: "auto-forward", | ||
| text: "Auto Forward", | ||
| }, | ||
| ]; | ||
|
|
||
| const buttonBar = document.getElementById("button-bar"); | ||
| const imageElement = document.getElementById("carousel-img"); | ||
|
|
||
| let index = 0; | ||
| let intervalId = null; | ||
|
|
||
| // Set initial image | ||
| imageElement.src = images[index]; | ||
|
|
||
| // Create buttons and add event listeners | ||
| buttons.forEach((item) => { | ||
| const button = document.createElement("button"); | ||
| button.type = item.type; | ||
| button.id = item.id; | ||
| button.textContent = item.text; | ||
| button.addEventListener("click", () => actButton(item.id)); | ||
| buttonBar.appendChild(button); | ||
| }); | ||
|
|
||
| function actButton(id) { | ||
| switch (id) { | ||
| case "auto-backward": | ||
| clearInterval(intervalId); | ||
| disableAutoButtons(); | ||
| intervalId = setInterval(backward, 2000); | ||
| break; | ||
|
|
||
| case "backward-btn": | ||
| backward(); | ||
| break; | ||
|
|
||
| case "stop": | ||
| clearInterval(intervalId); | ||
| enableAutoButtons(); | ||
| break; | ||
|
|
||
| case "forward-btn": | ||
| forward(); | ||
| break; | ||
|
|
||
| case "auto-forward": | ||
| clearInterval(intervalId); | ||
| disableAutoButtons(); | ||
| intervalId = setInterval(() => { | ||
| forward(); | ||
| }, 2000); | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| function disableAutoButtons() { | ||
| document.getElementById("auto-forward").disabled = true; | ||
| document.getElementById("auto-backward").disabled = true; | ||
| } | ||
|
|
||
| function enableAutoButtons() { | ||
| document.getElementById("auto-forward").disabled = false; | ||
| document.getElementById("auto-backward").disabled = false; | ||
| } | ||
|
|
||
| function backward() { | ||
| index = index === 0 ? images.length - 1 : index - 1; | ||
| imageElement.src = images[index]; | ||
| } | ||
|
|
||
| // Write your code here | ||
| function forward() { | ||
| index = (index + 1) % images.length; | ||
| imageElement.src = images[index]; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1,28 @@ | ||
| /** Write your CSS in here **/ | ||
| body { | ||
| object-fit: contain; | ||
| display: block; | ||
| } | ||
|
|
||
| #carousel-img { | ||
| width: 100%; | ||
| max-width: 400px; | ||
| height: auto; | ||
| display: block; | ||
| margin: 20px auto; | ||
| border-radius: 10px; | ||
| object-fit: contain; | ||
| box-shadow: 0 4px 8px rgba(0, 0, 0, 0.2); | ||
| } | ||
|
|
||
| #button-bar { | ||
| display: flex; | ||
| justify-content: center; | ||
| flex-wrap: wrap; | ||
| gap: 10px; | ||
| margin-top: 20px; | ||
| } | ||
|
|
||
| button { | ||
| color: blue; | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may want to double-check the opening and closing tags, especially around the button-bar
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, recheck your main HTML opening tag