London | 26-ITP-May | Jorvan White | Sprint 2 | Coursework by JorvanW · Pull Request #1418 · CodeYourFuture/Module-Data-Groups

JorvanW · 2026-08-10T21:55:18Z

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

Created Pull Request from Sprint 2 Coursework and updated for Pull Request

Poonam-raj · 2026-08-11T09:04:18Z

+test("creates a country currency code lookup for multiple codes",() => {
+  expect(createLookup(countryCurrencyPairs)).toEqual([[US, 'USD'], [CA, 'CAD'], [EN, 'GBP']]);
+})


You could test one currency pair first, maybe something not included in this list, and then move into a bigger list. Having two tests with different inputs really helps prove that things aren't hardcoded in your solution.

Poonam-raj · 2026-08-11T11:19:52Z

+function tally(array) {                    //(array) is the input to the function
+
+     if (!Array.isArray(array)){              //checking if array is actually an array
+  throw new Error("Input must be an array");
+  }
+
+  if (array.length === 0){                //if array is empty return a empty array 
+    return []
+  }
+
+
+  const result = {}                       //creates result as an empty object which will store the counts
+
+
+  for (const item of array){             //'for' loops through every item in the array 
+  if (result[item]){                    // checks if the item is already in the result{}
+      result[item]++}                   // If it is then '++' tells it to add 1 to the value 
+
+    else {
+      result[item] = 1;                // else is saying that if it doesn't exist then we give it a value of 1 


I generally appreciate the comments adding clarity for future ref and readers, but it's not needed and maybe makes the committed code messy. This solution is fairly easy to interpret without it and we want clean commits as much as possible

this did not remove comments - please remove unnecesary comments

Poonam-raj

Some great work writing tests and implementing solutions - a few comments worth addressing, especially in the interpret section where testing is particularly lacking

… properly

…object as required

…test cases for invert

Poonam-raj

Small remaining bits here - good work making corrections. I did leave some comments about test cases which you did not address in the implement section (particularly lookup), can you look at that and my other remainign comments - thanks!

JorvanW · 2026-08-17T15:51:14Z

I think github is down (at this time of writing) and there's some syncing issues but on my end the comments from the tally is gone and I currently can't load any of the comments you've made previously.

JorvanW added 14 commits July 20, 2026 19:32

Updated code for median.js to pass the late expectations

2c983b7

Added code to dedupe.js

6c109e9

added code for max.js

d57add3

Added code to sum.js

e3befbb

modified code on includes.js to use a for...of loop

872ddf0

Changed code in address. js to specify houseNumber

6c28930

Updated code and added notes for author.js

bbf0a73

update the code and added notes to recipe.js

5c2b4b5

Added code and tests for contains.js

663412b

added code to lookup.test

4c0d767

added code and passed tests for querystring.test.js

827b052

added code and tests for tally.test and js

2c0a94c

updated tests output for tally.test

f583fd7

added answers to invert.js and added a .test.js page to

93df342

This comment has been minimized.

Sign in to view

This comment has been minimized.

Sign in to view

Merge branch 'main' into coursework/sprint-2

6998347

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

removed code from sprint 1 and removed prep folder

5b96abc

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

This comment has been minimized.

Sign in to view

github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

removed file

f6cf1e1

JorvanW added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Aug 10, 2026

Poonam-raj added Review in progress This review is currently being reviewed. This label will be replaced by "Reviewed" soon. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Aug 11, 2026