Birmingham | 25-ITP-Sept | Joy Opachavalit | Sprint 2 | Feature/Book Library #336
Conversation
enjoy15
added
📅 Sprint 2
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md
cjyuan
added
Reviewed
Update index.html and script.js as per feedbacks. |
enjoy15
added
the
Needs Review
wankoak
removed
the
Reviewed
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
| const table = document.getElementById("display"); | ||
| table.innerHTML = "<tr><th>Title</th><th>Author</th><th>Pages</th><th>Read</th><th>Actions</th></tr>"; |
There was a problem hiding this comment.
Could also just clear <tbody>.
Note: There was a <tbody> in the original HTML code.
| myLibrary.forEach((book, index) => { | ||
| const row = table.insertRow(); | ||
| row.innerHTML = ` | ||
| <td>${book.title}</td> | ||
| <td>${book.author}</td> | ||
| <td>${book.pages}</td> | ||
| <td><button class="btn btn-success toggle-read" data-index="${index}">${book.check ? "Yes" : "No"}</button></td> | ||
| <td><button class="btn btn-warning delete-book" data-index="${index}">Delete</button></td> | ||
| `; | ||
| }); |
There was a problem hiding this comment.
If title and author contain special characters such as '<' and '&' they could messed up the HTML output.
| const index = e.target.dataset.index; | ||
| myLibrary.splice(index, 1); | ||
| render(); | ||
| alert("Book deleted successfully."); |
There was a problem hiding this comment.
Currently when the alert dialog box appears, the UI is still showing the deleted item. The UI is only updated after the user closes the dialog box.
Can you figure out how to make the alert dialog box appear only after the UI is updated?
Notes:
- This change is optional.
- In practice, it might not be a good idea to use
alert()to show any message.
cjyuan
added
Complete
3 participants
Learners, PR Template
Self checklist
Changelist