Skip to content

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Feature/book library #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

London | 25-ITP-May | Houssam Lahlah | Sprint 2 | Feature/book library #322

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
8bd778e
- change title.value to author.value.
HoussamLh Aug 18, 2025
bcdfde3
Merge branch 'CodeYourFuture:main' into feature/book-library
HoussamLh Aug 18, 2025
fff1b69
Merge branch 'CodeYourFuture:main' into feature/book-library
HoussamLh Sep 1, 2025
f439e87
Validate my HTML code online using W3.org
HoussamLh Sep 14, 2025
2537f48
Remove calling render() function to avoid duplicate
HoussamLh Sep 14, 2025
fd3649e
Fix the page number to passe and input as a number not as a string
HoussamLh Sep 14, 2025
94f7e3c
add a suffix like El and rename them to indicate DOM elements
HoussamLh Sep 14, 2025
b5a0f4b
Removes leading/trailing spaces and converts pages to a number and re…
HoussamLh Sep 15, 2025
b0c6627
Update to remove all rows at once and use innerText instead innerHTML
HoussamLh Sep 15, 2025
283fda2
Renamed submit() to submitBook() to avoid HTML form conflicts
HoussamLh Sep 15, 2025
b2a7d5e
fix: correct Book Library JS functionality
HoussamLh Sep 15, 2025
9adee93
add validation for page count input in Book Library
HoussamLh Sep 18, 2025
b16c7f2
Refactor table row creation to centralize cell creation and modulariz…
HoussamLh Sep 18, 2025
1de7803
update the render() function to delete just the the rows not the whol…
HoussamLh Sep 18, 2025
9b6df60
update the code to handle the toggle checkbox Read or Not Read
HoussamLh Sep 18, 2025
e953bb4
validate pages input to accept only positive whole numbers
HoussamLh Sep 19, 2025
25f7083
Refactor delete button to use index instead of book object
HoussamLh Sep 19, 2025
e5f6ec3
Refactor read/unread button creation to use a helper function
HoussamLh Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 10 additions & 24 deletions debugging/book-library/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,13 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
<title> Book Library </title>
<meta charset="utf-8">
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
<link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css">
<link rel="stylesheet" type="text/css" href="style.css">
</head>

<body>
Expand All @@ -31,42 +24,35 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
name="title"
required
/>
required>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
name="author"
required
/>
required>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
name="pages"
required
/>
required>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
value=""
/>Read
value="">Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
onclick="submitBook(event);">
</div>
</div>

Expand Down
135 changes: 61 additions & 74 deletions debugging/book-library/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,46 +1,46 @@
let myLibrary = [];

window.addEventListener("load", function (e) {
window.addEventListener("load", function () {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
true
);
myLibrary.push(book1);
myLibrary.push(book2);
render();
if (myLibrary.length === 0) {
const book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
const book2 = new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true);
myLibrary.push(book1, book2);
}
render();
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleEl = document.getElementById("title");
const authorEl = document.getElementById("author");
const pagesEl = document.getElementById("pages");
const checkEl = document.getElementById("check");

// Add book from form
function submitBook(event) {
// Prevent page reload
event.preventDefault();

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
) {
const titleVal = titleEl.value.trim();
const authorVal = authorEl.value.trim();
const pagesVal = Number(pagesEl.value);

if (!titleVal || !authorVal || !pagesVal) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
render();
return;
}

const book = new Book(titleVal, authorVal, pagesVal, checkEl.checked);
Copy link
Contributor

@cjyuan cjyuan Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Input could be any kind of numbers but some of them should not be considered a valid page count.
Can you add code to sanitize or reject these invalid value?

Copy link
Author

@HoussamLh HoussamLh Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi cjyuan,
Thank you for your guidence. you absoloutly right, I've add another if condition to handle the page number only and now submitBook() function validate the page count input.

  1. It now rejects invalid values such as 0, negative numbers, non-numeric input, or decimals.
  2. Only positive whole numbers are accepted as valid page counts.
  3. Users will see a clear alert message when their input doesn’t meet these rules.

Copy link
Contributor

@cjyuan cjyuan Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you tested the values which you said the app would reject? The modified code does not quite function the way you described here.

Copy link
Author

@HoussamLh HoussamLh Sep 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi cjyuan,

Thanks for catching that — I realized the behavior I described earlier didn’t fully match what was in the code (my mistake!).

I’ve now updated the validation to use a regex (/^\d+$/) instead of the simple Number() check. This ensures only positive whole numbers are accepted.

I tested with "0", "-5", and "12.5" — all of these are now correctly rejected, while "123" works as expected. Also, non-numeric characters like "abc" can’t even be typed into the input field anymore, so they’re automatically prevented at the keyboard level.

This should now fully match the intended behavior.

myLibrary.push(book);
render();

// Clear form
titleEl.value = "";
authorEl.value = "";
pagesEl.value = "";
checkEl.checked = false;
}

function Book(title, author, pages, check) {
Expand All @@ -51,53 +51,40 @@ function Book(title, author, pages, check) {
}

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
const table = document.getElementById("display");
const tbody = table.querySelector("tbody");
// clear old rows
tbody.innerHTML = "";

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
myLibrary.forEach((book, i) => {
const row = tbody.insertRow();
row.insertCell(0).textContent = book.title;
row.insertCell(1).textContent = book.author;
row.insertCell(2).textContent = book.pages;

changeBut.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
// Read/Unread button
const readCell = row.insertCell(3);
const readBtn = document.createElement("button");
readBtn.className = "btn btn-success";
readBtn.textContent = book.check ? "Yes" : "No";
readBtn.addEventListener("click", () => {
book.check = !book.check;
render();
});
readCell.appendChild(readBtn);

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
myLibrary.splice(i, 1);
render();
// Delete button
const delCell = row.insertCell(4);
Copy link
Contributor

@cjyuan cjyuan Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you think of the pros and cons of these two approaches for creating cells within a row?

  • Keeping all the cell creation code in one location, like the original code does.
  • Scattering the cell creation code across different locations, like what you did.

Copy link
Author

@HoussamLh HoussamLh Sep 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi cjyuan,

Thanks for the feedback! I see the pros and cons:

  • Keeping all cell creation code in one place makes the table structure clearer.
  • Splitting it up makes the logic around buttons easier to manage but reduces readability.

To balance both, I’ll keep the cell creation in one centralized block but move the button setup (delete, toggle read) into small helper function. That way, the row structure stays easy to follow while keeping the button logic modular.

const delBtn = document.createElement("button");
delBtn.className = "btn btn-warning";
delBtn.textContent = "Delete";
delBtn.addEventListener("click", () => {
if (confirm(`Are you sure you want to delete "${book.title}"?`)) {
myLibrary.splice(i, 1);
render();
}
});
}
delCell.appendChild(delBtn);
});
}

Loading