Repository navigation
Manchester | 26-SDC-Jun | Fithi Teklom | Sprint 2 |Improve code with caches - #264
Open
Fithi-Teklom wants to merge 5 commits into
Open
Fithi-Teklom wants to merge 5 commits into
Fithi-Teklom wants to merge 5 commits into
Conversation
cjyuan
reviewed
Oct 20, 2026
Comment on lines
17
to
37
| @@ -29,4 +37,5 @@ def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | |||
| intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:]) | |||
There was a problem hiding this comment.
Array and tuple creations are relatively costly operations.
We could observe that coins can only be one of the following 9 arrays:
[200, 100, 50, 20, 10, 5, 2, 1]
[100, 50, 20, 10, 5, 2, 1]
[50, 20, 10, 5, 2, 1]
...
[1]
[]
We could further improve the performance if we can
- avoid repeatedly creating the same sub-arrays at line 37 (e.g. use another cache), and
- create key as (total, a_unique_integer_identifying_the_subarray) instead of as (total, tuple of coins)
- There are only a small number of different subarrays. We can easily assign each subarray a unique integer.
cjyuan
reviewed
Oct 21, 2026
Comment on lines
+10
to
+19
| return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1]) | ||
|
|
||
| return ways_to_make_change_helper(total, 0) | ||
|
|
||
| def ways_to_make_change_helper(total: int, coins: List[int]) -> int: | ||
| def ways_to_make_change_helper(total: int, coin_list_id: int) -> int: |
There was a problem hiding this comment.
-
We could also pass both the list and
coin_list_idto the helper function. This way, we could keep the coin list local and make the helper reusable for different coin list. -
We could also rename
coin_list_idand use it as the starting index of the sub list, and modify the loop (and few conditions) to iterate through the sub list. This way, we don't need to allocate additional space on lines 4-9.
|
Changes look good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1182
Changelist
Complete Fabonacci and Making improvement with cache exercise.