Skip to content

Manchester | 26-SDC-Jun | Fithi Teklom | Sprint 2 |Improve code with caches - #264

Open
Fithi-Teklom wants to merge 5 commits into
CodeYourFuture:mainfrom
Fithi-Teklom:feature/improve-with-caches
Open

Fithi-Teklom wants to merge 5 commits into
CodeYourFuture:mainfrom
Fithi-Teklom:feature/improve-with-caches

Conversation

@Fithi-Teklom

Copy link
Copy Markdown

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1182

Changelist

Complete Fabonacci and Making improvement with cache exercise.

@Fithi-Teklom Fithi-Teklom added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 19, 2026
Comment on lines 17 to 37
@@ -29,4 +37,5 @@ def ways_to_make_change_helper(total: int, coins: List[int]) -> int:
intermediate = ways_to_make_change_helper(total - total_from_coins, coins=coins[coin_index+1:])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Array and tuple creations are relatively costly operations.

We could observe that coins can only be one of the following 9 arrays:

[200, 100, 50, 20, 10, 5, 2, 1]
[100, 50, 20, 10, 5, 2, 1]
[50, 20, 10, 5, 2, 1]
...
[1]
[]

We could further improve the performance if we can

  • avoid repeatedly creating the same sub-arrays at line 37 (e.g. use another cache), and
  • create key as (total, a_unique_integer_identifying_the_subarray) instead of as (total, tuple of coins)
    • There are only a small number of different subarrays. We can easily assign each subarray a unique integer.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 20, 2026
@Fithi-Teklom Fithi-Teklom added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 20, 2026
Comment on lines +10 to +19
return ways_to_make_change_helper(total, [200, 100, 50, 20, 10, 5, 2, 1])

return ways_to_make_change_helper(total, 0)

def ways_to_make_change_helper(total: int, coins: List[int]) -> int:
def ways_to_make_change_helper(total: int, coin_list_id: int) -> int:

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • We could also pass both the list and coin_list_id to the helper function. This way, we could keep the coin list local and make the helper reusable for different coin list.

  • We could also rename coin_list_id and use it as the starting index of the sub list, and modify the loop (and few conditions) to iterate through the sub list. This way, we don't need to allocate additional space on lines 4-9.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 21, 2026
@Fithi-Teklom Fithi-Teklom added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 21, 2026
@cjyuan

cjyuan commented Oct 21, 2026

Copy link
Copy Markdown

Changes look good.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants