Skip to content

London | 26-Jul-SDC | Shaghayegh far| Sprint 2 | Implement LRU Cache - #250

Open
shaghayeghfar wants to merge 2 commits into
CodeYourFuture:mainfrom
shaghayeghfar:implement_lru_cache
Open

shaghayeghfar wants to merge 2 commits into
CodeYourFuture:mainfrom
shaghayeghfar:implement_lru_cache

Conversation

@shaghayeghfar

Copy link
Copy Markdown

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Task code

CYF-1181

Changelist

Implemented an LRU cache using a dictionary and doubly linked list to support O(1) get and set operations.

@shaghayeghfar shaghayeghfar added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 14, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To better adhere to the Single-Responsibility Principle (SRP) from SOLID design principles, it's preferable to implement the "doubly linked list" and the "LRU Cache" as separate classes, with the linked list used inside LruCache to manage ordering.

You could copy your linked_list.py to this folder.

Alternatively, use a suitable Python built-in class to maintain order.

Could you update your code using one of these approaches?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 14, 2026
@shaghayeghfar

Copy link
Copy Markdown
Author

Dear @cjyuan
Thank you for your feedback! I've updated my code by separating the doubly linked list and the LRU cache into two classes, so each class has its own responsibility. I really appreciate your guidance and support!

@shaghayeghfar shaghayeghfar added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 14, 2026

@cjyuan cjyuan left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks correct.

Note: A typical linked list node stores one value (instead of a key and a value). Even if it stores only one value, we could still store the key/value pair as a tuple in the linked list node.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants