Repository navigation
NW| 26-Jul-SDC | Ahmad Hmedan | Sprint 2 | Improve code with precomputing - #236
Open
AhmadHmedann wants to merge 4 commits into
Open
AhmadHmedann wants to merge 4 commits into
AhmadHmedann wants to merge 4 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
AhmadHmedann
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
Bot
removed
the
Needs Review
AhmadHmedann
added
the
Needs Review
cjyuan
reviewed
Oct 10, 2026
Comment on lines
+10
to
+16
| seen = set() | ||
| longest = "" | ||
| for string_index, string in enumerate(strings): | ||
| for other_string in strings[string_index+1:]: | ||
| common = find_common_prefix(string, other_string) | ||
| if len(common) > len(longest): | ||
| longest = common | ||
| return longest | ||
|
|
||
| for string in strings: | ||
| for i in range(1, len(string) + 1): | ||
| prefix = string[:i] | ||
| if prefix in seen and len(prefix) > len(longest): | ||
| longest = prefix |
There was a problem hiding this comment.
Can you use complexity to explain how the new implementation is better than the original implementation?
cjyuan
added
Reviewed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Task code
CYF-1183
Changelist
Speed up the solutions by introducing precomputing