fix(a11y): dark-adapt stroke tokens for dark mode - #27
Conversation
Remap dark --Colors-Stroke-* onto dark neutrals/primary so borders no longer glow near-white on dark surfaces, and dark-adapt the tertiary button border token consumers were patching locally. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 32 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
Comment |
Summary
Closes #23 (D12). Dark mode redefined every
--Colors-Stroke-*token to the same light-mode near-white neutrals, so borders and dividers glowed on dark surfaces. ChatCPT already patched two consumers locally.Visual change for all DS consumers. Design has signed off for ChatCPT Wave 4.
Changes
Neutral strokes invert onto the dark scale, keeping Lighter → Stronger as increasing contrast against
Backgrounds-Main-Top(Neutral-1300):--Colors-Buttons-Tertiary-Defaultis the tertiary border (Neutral-300in light) and had the same miss. Dark now usesNeutral-1100, matching ChatCPT's existing override.Look at the dark block in
colors/colors.css. Components that already dark-adapt their own borders (boxes, tags, dropdown hover) keep those overrides.Test plan
npm test— stroke tokens in dark are not the light near-white scale; A7/A8 contrast tests still passcolors/test.htmlin dark: stroke swatches sit on the dark neutrals, not#E7EAF2/#F4F5F9app.csstertiary-border override. Rest-pill usesStroke-Lightat 0.5 opacity, so that dark override may still be needed (grip vs hairline).