Skip to content

fix(a11y): add optional accessible-name overrides - #25

Merged
BrianGenisio merged 1 commit into
mainfrom
fix/a11y-d9-accessible-name-overrides
Aug 13, 2026
Merged

fix(a11y): add optional accessible-name overrides#25
BrianGenisio merged 1 commit into
mainfrom
fix/a11y-d9-accessible-name-overrides

Conversation

@BrianGenisio

Copy link
Copy Markdown
Contributor

Summary

Closes #20 (D9 from the ChatCPT WCAG 2.2 AA audit).

Modal and slider now accept optional accessible-name overrides so consumers can pass already-translated strings. English defaults stay when the options are omitted. There is no i18n runtime in the design system.

Changes

  • Modal: closeButtonLabel (default 'Close modal')
  • Slider: handleLabel, minHandleLabel, maxHandleLabel (defaults 'Value', 'Minimum value', 'Maximum value')
  • Dropdown: no new option. placeholder is already the combobox accessible name when nothing is selected; README / agents.md now say to pass a translated string.

Existing constructors keep working. ChatCPT should pass t(...) after the submodule bump (settings close button, model dropdown placeholder). The temperature slider already replaces aria-label with aria-labelledby, so it does not need handleLabel.

This PR is independent of #24 (D8/D10/D11). Both touch modal.js / the modal README, so rebase this branch if #24 lands first.

Test plan

  • Modal default close label is Close modal; override is used when provided
  • Slider default handle labels stay English; translated overrides apply to single and range
  • Dropdown default placeholder is Select option; custom placeholder is the combobox name
  • npm test (existing slider / dropdown / contrast suites unchanged)

Modal and slider accept already-translated label strings. English
defaults stay when omitted. Dropdown placeholder is already the
combobox name; document that consumers should pass a translated one.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 15 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1c205ac4-8211-49cc-a213-f599cbae6aca

📥 Commits

Reviewing files that changed from the base of the PR and between d21d15d and 3baee8c.

📒 Files selected for processing (7)
  • agents.md
  • components/dropdown/README.md
  • components/modal/README.md
  • components/modal/modal.js
  • components/numeric-slider/README.md
  • components/numeric-slider/numeric-slider.js
  • tests/accessible-names.spec.js

Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit 9a3d15e into main Aug 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y][D9] Hardcoded English accessible names

1 participant