fix(a11y): add optional accessible-name overrides - #25
Conversation
Modal and slider accept already-translated label strings. English defaults stay when omitted. Dropdown placeholder is already the combobox name; document that consumers should pass a translated one. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 15 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
Comment |
Summary
Closes #20 (D9 from the ChatCPT WCAG 2.2 AA audit).
Modal and slider now accept optional accessible-name overrides so consumers can pass already-translated strings. English defaults stay when the options are omitted. There is no i18n runtime in the design system.
Changes
closeButtonLabel(default'Close modal')handleLabel,minHandleLabel,maxHandleLabel(defaults'Value','Minimum value','Maximum value')placeholderis already the combobox accessible name when nothing is selected; README /agents.mdnow say to pass a translated string.Existing constructors keep working. ChatCPT should pass
t(...)after the submodule bump (settings close button, model dropdown placeholder). The temperature slider already replacesaria-labelwitharia-labelledby, so it does not needhandleLabel.This PR is independent of #24 (D8/D10/D11). Both touch
modal.js/ the modal README, so rebase this branch if #24 lands first.Test plan
Close modal; override is used when providedSelect option; custom placeholder is the combobox namenpm test(existing slider / dropdown / contrast suites unchanged)