fix(a11y): raise dark primary and body text contrast tokens (A7, A8) - #18
Conversation
Lighten Primary-Default in dark mode for focus-ring 3:1, and remap Text-Body-Light/Lighter (plus dark secondary button) to clear 4.5:1. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 25 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (5)
Comment |
Summary
Closes #11 ([a11y][A7]) and #12 ([a11y][A8]). Shared semantic tokens now meet WCAG AA contrast against
Backgrounds-Main-Topin both themes. Visual change for all DS consumers — please confirm with design-system owners before merge.Token changes
--Colors-Primary-Default(A7)Primary-700(5.05:1)Primary-700→Primary-450(~5.5:1 vs#1D2740)--Colors-Text-Body-Lighter(A8)Neutral-800→Neutral-950(~5.7:1)Neutral-900→Neutral-700(~5.6:1)--Colors-Text-Body-LightNeutral-900→Neutral-1000(keeps Light ≥ Lighter; fixes placeholders)Neutral-750→Neutral-650--Colors-Buttons-Secondary-*(dark)Primary-450; Hover →Primary-400; Pressed →Primary-500Primary filled buttons still use
--Colors-Buttons-Primary-*(Primary-700) and are unchanged.Notes for consumers
--Colors-Text-Body-Lighterwithopacity. Documented incolors/README.md. ChatCPT’s.composer__hint { opacity: 0.8 }will still fail in light until that opacity is removed (handle in the submodule bump PR).learn_cosmo-chatsubmodule bump in this PR.Test plan
npm test—tests/contrast-tokens.spec.jsmeasures Primary-Default ≥ 3:1 and body/secondary text ≥ 4.5:1 in light + dark; existing dropdown/slider suites greenMade with Cursor