Skip to content

fix(a11y): raise dark primary and body text contrast tokens (A7, A8) - #18

Merged
BrianGenisio merged 1 commit into
mainfrom
fix/a11y-a7-a8-contrast-tokens
Aug 12, 2026
Merged

fix(a11y): raise dark primary and body text contrast tokens (A7, A8)#18
BrianGenisio merged 1 commit into
mainfrom
fix/a11y-a7-a8-contrast-tokens

Conversation

@BrianGenisio

Copy link
Copy Markdown
Contributor

Summary

Closes #11 ([a11y][A7]) and #12 ([a11y][A8]). Shared semantic tokens now meet WCAG AA contrast against Backgrounds-Main-Top in both themes. Visual change for all DS consumers — please confirm with design-system owners before merge.

Token changes

Token Light Dark
--Colors-Primary-Default (A7) unchanged Primary-700 (5.05:1) Primary-700Primary-450 (~5.5:1 vs #1D2740)
--Colors-Text-Body-Lighter (A8) Neutral-800Neutral-950 (~5.7:1) Neutral-900Neutral-700 (~5.6:1)
--Colors-Text-Body-Light Neutral-900Neutral-1000 (keeps Light ≥ Lighter; fixes placeholders) Neutral-750Neutral-650
--Colors-Buttons-Secondary-* (dark) Default/Text → Primary-450; Hover → Primary-400; Pressed → Primary-500

Primary filled buttons still use --Colors-Buttons-Primary-* (Primary-700) and are unchanged.

Notes for consumers

  • Do not fade --Colors-Text-Body-Lighter with opacity. Documented in colors/README.md. ChatCPT’s .composer__hint { opacity: 0.8 } will still fail in light until that opacity is removed (handle in the submodule bump PR).
  • No learn_cosmo-chat submodule bump in this PR.

Test plan

  • npm testtests/contrast-tokens.spec.js measures Primary-Default ≥ 3:1 and body/secondary text ≥ 4.5:1 in light + dark; existing dropdown/slider suites green
  • Design-system owner visual review (shared token impact)
  • After submodule bump: re-measure ChatCPT sidebar labels, placeholders, secondary button; drop composer hint opacity if still failing

Made with Cursor

Lighten Primary-Default in dark mode for focus-ring 3:1, and remap
Text-Body-Light/Lighter (plus dark secondary button) to clear 4.5:1.

Co-authored-by: Cursor <cursoragent@cursor.com>
@coderabbitai

coderabbitai Bot commented Aug 12, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 25 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 62523f22-b4d0-4720-8838-3a1d76ff815e

📥 Commits

Reviewing files that changed from the base of the PR and between 4488dc4 and 1c8d8c1.

📒 Files selected for processing (5)
  • colors/README.md
  • colors/colors.css
  • components/button/button.css
  • tests/contrast-tokens.spec.js
  • tests/fixtures/contrast-tokens.html

Comment @coderabbitai help to get the list of available commands.

@BrianGenisio
BrianGenisio merged commit d5503bb into main Aug 12, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[a11y][A7] Focus ring contrast is 2.94:1 in dark mode (Primary-Default token)

1 participant