fix: roster search covers email; click a domain to find every account from it - #191
Merged
Merged
Conversation
The email check only ran when the query contained an "@", so a bare domain or local-part substring never matched. Search email for any query; the roster is filtered before pagination, so this spans every page. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ
…from it The domain part of each row's email searches `@domain` across the whole roster; the search box follows the URL so the query is visible and editable. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found on the first day of triage (
plans/roster-email-search.md):@— an accidental gate inlistMembers. Email is now searched for every query. Search was already server-side across the whole roster (filter, then paginate); that's unchanged.@domain, so one throwaway address leads to every account from that domain. The search box follows the URL so the query is visible and editable.Regression test:
q=example.orgreturns both seeded members with that domain.🤖 Generated with Claude Code
https://claude.ai/code/session_01LFyA5poHwrhAktrnsKrUiQ