codeforphilly-ng: drop pvc-data; data is emptyDir now#167
Merged
Conversation
Upstream PR #86 (codeforphilly-ng) eliminated the working tree on the pod's data clone — the API now operates on a bare clone backed by an emptyDir. The upstream pvc-data.yaml manifest was deleted, so: - .holo/branches/k8s-manifests/codeforphilly-ng/app/manifests.toml drops the pvc-data.yaml file from the holomapping projection list. - codeforphilly-ng/app/kustomization.yaml drops the corresponding resources reference so kubectl apply doesn't try to reach for a manifest that no longer exists. After projection + merge: the running pod's data PVC becomes unreferenced; rollout-restart will mount an emptyDir instead and the entrypoint bare-clones from origin on first boot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cluster-side counterpart to codeforphilly-ng#86, which eliminated the working tree on the pod's data clone. The upstream `pvc-data.yaml` manifest was deleted in that PR, so:
After this merges + the next k8s-manifests projection runs, the deployment's `data` volume becomes an `emptyDir{}` (already in the upstream deployment.yaml). A pod rollout-restart will mount the fresh emptyDir and the entrypoint bare-clones from origin on first boot.
Test plan