codeforphilly-ng: seal CFP_DATA_RELOAD_SECRET for hot-reload webhook#165
Merged
Conversation
The codeforphilly-ng API exposes `POST /api/_internal/reload-data` (CodeForPhilly/codeforphilly-ng#70) for the `codeforphilly-data` repo's `Notify deployments` GH Action to call on push to `published`. The bearer secret on both sides must match. This seals the cluster-side copy; the data-repo-side copy is added as a GitHub repository secret on `codeforphilly-data`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the bearer secret the running
codeforphilly-ngAPI expects onPOST /api/_internal/reload-data(the hot-reload webhook landed upstream in CodeForPhilly/codeforphilly-ng#70). On push to the data repo'spublishedbranch,codeforphilly-data's GH Action will POST to that endpoint withAuthorization: Bearer <secret>; the bearer must match the env value materialized from this sealed Secret.Changes
codeforphilly-ng.secrets/codeforphilly-secrets.yaml— re-sealed to addCFP_DATA_RELOAD_SECRETalongside the existing 4 keys (CFP_JWT_SIGNING_KEY,CFP_DATA_REMOTE,GITHUB_OAUTH_CLIENT_ID,GITHUB_OAUTH_CLIENT_SECRET). All previous values preserved.After merge
codeforphillydeployment once the projection lands so the pod's process picks up the new env var (env vars fromenvFrom: secretRefaren't hot-reloaded into a running container).codeforphilly-data's repository secrets so the GH Action's bearer matches.