feat: move Eligibility Checks into overflow menu in home nav#354
Open
morissette wants to merge 1 commit intoCodeForPhilly:mainfrom
Open
feat: move Eligibility Checks into overflow menu in home nav#354morissette wants to merge 1 commit intoCodeForPhilly:mainfrom
morissette wants to merge 1 commit intoCodeForPhilly:mainfrom
Conversation
Eligibility Checks was presented as a peer tab alongside Screeners, giving it equal visual weight. Per CodeForPhilly#289, move it into a '...' overflow menu on the right side of the navbar so Screeners is clearly the primary navigation item. - BdtNavbar: add optional menuDef prop that renders a three-dot menu button with a dropdown on the right side of the navbar - HomeScreen: move 'Eligibility checks' tab into menuDef items Closes CodeForPhilly#289
2d9ba27 to
246b174
Compare
prestoncabe
requested changes
Mar 12, 2026
Collaborator
There was a problem hiding this comment.
Thanks @morissette - The menu appears to look and function well, but now I think there is an unintended consequence where we lose a visual indicator of which area of the app we're in.
Before this acted as a tab, with an underline:
curious if @Justin-MacIntosh or @Michael-Dratch or @earth-walker have any thoughts on this - My naive thought is that when you navigate to Eligibility Checks, the nav bar would clear except for a bold "Eligibility Checks" title and a "Back to Home" link would be added to the top right. (This would be consistent to the behavior when navigating into a particular screener):
Contributor
Author
|
Thinking about these requested changes, should find time to work on them today. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #289
Summary
Eligibility Checks was presented as a peer tab alongside Screeners in the home screen navbar, giving it equal visual prominence. This moves it into a
...overflow menu on the right side of the navbar so Screeners is clearly the primary navigation item.Before: Two equal tabs —
Screeners|Eligibility checksAfter: One primary tab —
Screeners— with a...menu button on the right that revealsEligibility Checksin a dropdown.Changes
BdtNavbar.tsxmenuDefprop ({ items: { key, label, onClick }[] })...button (using the existingMenuIcon) right-aligned in the navbartabDefs.map()to<For>(Solid.js idiomatic)HomeScreen.tsxchecksfromtabDefsmenuDefwithEligibility Checksas the single menu itemTest plan
...button appears on the right side of the navbar...opens a dropdown with "Eligibility Checks"🤖 Generated with Claude Code