Skip to content

feat: move Eligibility Checks into overflow menu in home nav#354

Open
morissette wants to merge 1 commit intoCodeForPhilly:mainfrom
morissette:de-emphasize-custom-checks
Open

feat: move Eligibility Checks into overflow menu in home nav#354
morissette wants to merge 1 commit intoCodeForPhilly:mainfrom
morissette:de-emphasize-custom-checks

Conversation

@morissette
Copy link
Contributor

@morissette morissette commented Mar 11, 2026

Closes #289

Summary

Eligibility Checks was presented as a peer tab alongside Screeners in the home screen navbar, giving it equal visual prominence. This moves it into a ... overflow menu on the right side of the navbar so Screeners is clearly the primary navigation item.

Before: Two equal tabs — Screeners | Eligibility checks

After: One primary tab — Screeners — with a ... menu button on the right that reveals Eligibility Checks in a dropdown.

Changes

BdtNavbar.tsx

  • Add optional menuDef prop ({ items: { key, label, onClick }[] })
  • When provided, renders a ... button (using the existing MenuIcon) right-aligned in the navbar
  • Clicking opens a dropdown; clicking outside or selecting an item closes it
  • Refactored tabDefs.map() to <For> (Solid.js idiomatic)

HomeScreen.tsx

  • Remove checks from tabDefs
  • Add menuDef with Eligibility Checks as the single menu item

Test plan

  • Home screen loads with only "Screeners" tab visible
  • ... button appears on the right side of the navbar
  • Clicking ... opens a dropdown with "Eligibility Checks"
  • Clicking "Eligibility Checks" switches the view and closes the dropdown
  • Clicking outside the menu closes the dropdown
  • Navigating back from a screener still shows the correct home view

🤖 Generated with Claude Code

@morissette morissette requested a review from prestoncabe as a code owner March 11, 2026 02:00
Eligibility Checks was presented as a peer tab alongside Screeners,
giving it equal visual weight. Per CodeForPhilly#289, move it into a '...' overflow
menu on the right side of the navbar so Screeners is clearly the
primary navigation item.

- BdtNavbar: add optional menuDef prop that renders a three-dot menu
  button with a dropdown on the right side of the navbar
- HomeScreen: move 'Eligibility checks' tab into menuDef items

Closes CodeForPhilly#289
@morissette morissette force-pushed the de-emphasize-custom-checks branch from 2d9ba27 to 246b174 Compare March 11, 2026 02:05
Copy link
Collaborator

@prestoncabe prestoncabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @morissette - The menu appears to look and function well, but now I think there is an unintended consequence where we lose a visual indicator of which area of the app we're in.

Before this acted as a tab, with an underline:

Image

curious if @Justin-MacIntosh or @Michael-Dratch or @earth-walker have any thoughts on this - My naive thought is that when you navigate to Eligibility Checks, the nav bar would clear except for a bold "Eligibility Checks" title and a "Back to Home" link would be added to the top right. (This would be consistent to the behavior when navigating into a particular screener):

Image

@morissette
Copy link
Contributor Author

Thinking about these requested changes, should find time to work on them today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

De-emphasize Custom Checks in UI navigation

2 participants