Skip to content

Conversation

@luiskcc
Copy link
Collaborator

@luiskcc luiskcc commented Nov 3, 2025

…view

  • Changed default graph view from 'day' to 'week'
  • Updated week calculation to use calendar weeks (Monday-Sunday) instead of rolling 7-day window
  • Fixed duplicate Sunday issue by filtering chart data to only include days within range
  • Updated both current and previous week calculations for consistency
  • Enabled Tide Goals feature in dev mode
image image

…view

   - Changed default graph view from 'day' to 'week'
   - Updated week calculation to use calendar weeks (Monday-Sunday) instead of rolling 7-day window
   - Fixed duplicate Sunday issue by filtering chart data to only include days within range
   - Updated both current and previous week calculations for consistency
   - Enabled Tide Goals feature in dev mode
@luiskcc
Copy link
Collaborator Author

luiskcc commented Nov 3, 2025

I am missing a few things:

-Interactivity to the week graph bars so clicking on a day navigates to that day view,
-Current day has the hover background gray effect background by default so people can spot the day

  • Easy sideways drag or click sideways to navigate across weeks

}

return Object.entries(buckets)
.sort(([keyA], [keyB]) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you provide more information about what this change is about? I'm assuming there is a bug?

Copy link
Collaborator Author

@luiskcc luiskcc Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The date keys (e.g., "2025-11-03", "2025-11-04") were coming out in random order. This caused the graph to show days like: Tue, Wed, Mon... etc(wrong order). Adding localeCompare() sorts the ISO date strings alphabetically, which gives us chronological order: Mon... Sun

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are they not currently in order? I haven't seen this issue yet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants