Skip to content

Conversation

@rphovley
Copy link
Member

@rphovley rphovley commented Nov 9, 2024

The Pull Request is ready

  • all github actions are passing
  • are changes backwards compatible?
  • fixes #0
  • the branch follows the naming schema issue-123-enable-x-does-not-disable-y
  • the pull request has a sensible title

Intention

With this change I intend to cleanup several small bugs

Review Points

Please take extra care reviewing...

The code follows best practices

  • the code is readable
  • issues for follow-up tasks have been created
  • there is no any type used

Notes

@github-actions
Copy link
Contributor

github-actions bot commented Nov 9, 2024

Visit the preview URL for this PR (updated for commit bddd23e):

https://codeclimbersio--pr264-issue-0-cleanup-z9hf5bw4.web.app

(expires Sat, 16 Nov 2024 04:58:45 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 3c28ab1d661a7526dc2530b2448a1aa4f88d23d4

@rphovley rphovley merged commit 41aa221 into main Nov 9, 2024
10 of 11 checks passed
@rphovley rphovley deleted the issue-0/cleanup branch November 9, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants