Repository navigation
feat: keep the review guide's request in the review artifact - #177
Draft
Svilen-Stefanov wants to merge 1 commit into
Draft
Svilen-Stefanov wants to merge 1 commit into
Svilen-Stefanov wants to merge 1 commit into
Conversation
A review now saves the body it POSTs to /v1/review-guide, the same xz-compressed bytes, as closed/bundle.json.xz in the review artifact. The artifact held the analyses and the guide but not the call graphs the guide is generated from, so no guide could be generated again on the same inputs. With the request kept, any change to the guide can be compared old against new on real pull requests. It is written only when the guide's request goes out, so never in sync mode, never for a provider the service cannot call, and never when the inputs are missing or over the service's limit. Writing it never fails the run or changes the guide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
CodeBoarding reviewStatus: 1 changed component See the full change in CodeBoarding. graph LR
n_Action_Workflow_and_Analysis_Execution["Action Workflow and Analysis Execution"]
n_Remote_Review_and_Problem_Ledger["Remote Review and Problem Ledger"]
classDef added fill:#1f883d,stroke:#0b5d23,color:#ffffff;
classDef modified fill:#bf8700,stroke:#7d4e00,color:#ffffff;
classDef deleted fill:#cf222e,stroke:#82071e,color:#ffffff,stroke-dasharray:5 3;
class n_Remote_Review_and_Problem_Ledger modified;
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
In review mode,
scripts/remote_features.pynow saves the body it POSTs to/v1/review-guideinto the review artifact asclosed/bundle.json.xz. It is the same bytes the service receives (xz-compressed JSON, so the name says.xz, not.gz), not a re-encoding.Why
Review artifacts carry
analysis.json,metadata.json,health_report.json,review_guide.jsonandclosed/architecture.json, but not the call graphs the guide is generated from, so no guide can be generated again on the same inputs. Keeping the request lets every guide change (starting with the prompt and packet change in licensing-aws) be compared old against new on real pull requests. A separate job will copy bundles into CodeBoarding-evals before they expire.This adds no closed logic: it stores the inputs the action already sends, nothing more.
When it is written
mode == 'review'; sync's one remote call (problem_history.py,/v1/briefing) writes no artifact. A test checks both._encodealready refuses these before anything is sent, and the existing notice says why).keep_bundlealso refuses an empty body or one overMAX_COMPRESSED_BYTESitself, with one::notice::line.source.json. Architecture's body (which may carry the repository's source) is not kept.Size
Measured by running this branch's collection and encoding path, with the pinned engine (
codeboarding==0.15.6), on real baselines and with the POST stubbed:The service caps the body at 4.3 MB, so that is the most it can add. xz output does not shrink further in the artifact zip. The review artifact keeps its 14-day
retention-days; nothing about retention changes.problem_history.pydownloads review artifacts only up to 50 MB, far above this.The webview ignores it
CodeBoarding-webview inflates only the names in
PR_ARTIFACT_FILES(src/lib/pr-artifact.ts:562onmainat 569db1c:analysis.json,metadata.json,base_analysis.json,health_report.json,review_guide.json,closed/review-guide.json,closed/architecture.json), via thereadZipEntriesfilter. No other reader there walksclosed/. The new file is never read or inflated.Tests
KeptBundleTestsintests/test_remote_features.py:problem_history.py)Full suite: 359 tests pass.
Draft: not to be merged or released from here; the
v1tag is untouched.🤖 Generated with Claude Code