Skip to content

Fix Clear Button Show on ReadOnly Components #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mckaragoz merged 1 commit into from
Apr 8, 2026
Merged

Fix Clear Button Show on ReadOnly Components #620

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docs/CodeBeam.MudBlazor.Extensions.Docs.Wasm/wwwroot/CodeBeam.MudBlazor.Extensions.xml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions src/CodeBeam.MudBlazor.Extensions/Components/ComboBox/MudComboBox.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
@inject IKeyInterceptorService KeyInterceptorService
@inject IScrollManagerExtended ScrollManagerExtended

<CascadingValue Name="Standalone" Value="false" IsFixed="true">
<CascadingValue Name="SubscribeToParentForm" Value="false" IsFixed="true">
<CascadingValue Value="@this" IsFixed="true">
<div class="mud-select-extended" id="@_elementId">
<MudInputControl Label="@Label" Variant="@Variant" HelperText="@HelperText" HelperTextOnFocus="@HelperTextOnFocus" FullWidth="@FullWidth" Margin="@Margin" Class="@Classname" Style="@Style"
Expand All @@ -22,7 +22,7 @@
Underline="@Underline"
HasAdornmentStart="@(AdornmentStart != null)" HasAdornmentEnd="@(AdornmentEnd != null)"
Disabled="@GetDisabledState()" ReadOnly="@GetReadOnlyState()" Error="@ErrorState.Value" ErrorId="@ErrorIdState.Value"
Clearable="@Clearable" ForceClearable="@(Clearable && HasValue(ReadValue))" OnClearButtonClick="@ClearButtonClickHandlerAsync"
Clearable="@(Clearable && !GetReadOnlyState())" ForceClearable="@ForceClearable" OnClearButtonClick="@ClearButtonClickHandlerAsync"
MaxLength="@MaxLength" @attributes="UserAttributes" OnBlur="@HandleOnBlur" ShrinkLabel="@(HasValue(ReadValue) || AdornmentStart != null || _isOpen || ShrinkLabel)">

<AdornmentStart>
Expand Down
12 changes: 11 additions & 1 deletion src/CodeBeam.MudBlazor.Extensions/Components/ComboBox/MudComboBox.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -379,6 +379,13 @@ protected internal void SetSearchString(T value)
//[Category(CategoryTypes.List.Behavior)]
//public bool Virtualize { get; set; }

/// <summary>
/// If true, clear button forced to show even on readonly or disabled ComboBox.
/// </summary>
[Parameter]
[Category(CategoryTypes.List.Behavior)]
public bool ForceClearable { get; set; }

/// <summary>
/// If true, chips has close button and remove from SelectedValues when pressed the close button.
/// </summary>
Expand Down Expand Up @@ -757,6 +764,7 @@ protected override void OnInitialized()
bool _oldShowCheckbox = true;
bool _oldBordered;
Dense _oldDense = Dense.Standard;
bool _oldReadonly;
/// <summary>
///
/// </summary>
Expand All @@ -765,14 +773,16 @@ protected override void OnParametersSet()
base.OnParametersSet();
if (_oldShowCheckbox != ShowCheckbox ||
_oldBordered != Bordered ||
_oldDense != Dense)
_oldDense != Dense ||
_oldReadonly != ReadOnly)
{
ForceRenderItems();
}
_oldShowCheckbox = ShowCheckbox;
_oldBordered = Bordered;
_oldDense = Dense;
_allSelected = GetAllSelectedState();
_oldReadonly = ReadOnly;
}

bool _firstRendered = false;
Expand Down
16 changes: 5 additions & 11 deletions src/CodeBeam.MudBlazor.Extensions/Components/InputExtended/MudInputExtended.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,35 +316,29 @@ public override ValueTask SelectRangeAsync(int pos1, int pos2)

private Size GetButtonSize() => Margin == Margin.Dense ? Size.Small : Size.Medium;

//private bool _showClearable;

private void UpdateClearable(object? value)
{
var showClearable = HasValue((T?)value);
if (Clearable != showClearable)
Clearable = showClearable;
}

//private bool GetClearable() => Clearable && ((ReadValue is string stringValue && !string.IsNullOrWhiteSpace(stringValue)) || (ReadValue is not string && ReadValue is not null));

private bool ShowClearButton()
{
if (GetDisabledState())
{
return false;
}

if (!Clearable)
if (SubscribeToParentForm && GetReadOnlyState())
{
return false;
}

// TODO: Add SubscribeToParentForm and GetReadOnlyState from MudBaseInput when Mud 9 released, it's currently internal
// Select extended is currently hardcoded readonly true, do not uncomment
//if (ReadOnly)
//{
// return false;
//}
if (!Clearable)
{
return false;
}

return HasValue(ReadValue);
}
Expand Down
4 changes: 2 additions & 2 deletions src/CodeBeam.MudBlazor.Extensions/Components/SelectExtended/MudSelectExtended.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
@typeparam T
@inherits MudBaseInputExtended<T>

<CascadingValue Name="Standalone" Value="false" IsFixed="true">
<CascadingValue Name="SubscribeToParentForm" Value="false" IsFixed="true">
<CascadingValue Value="@this" IsFixed="true">
<div class="mud-select-extended" style="@(Disabled ? "pointer-events: none" : null)" id="@_elementId">
<MudInputControl
Expand All @@ -29,7 +29,7 @@
HasAdornmentStart="@(AdornmentStart != null)" HasAdornmentEnd="true"
Value="@(Strict && !IsValueInList ? null : ReadText)" Underline="@Underline"
Disabled="@GetDisabledState()" ReadOnly="true" Error="@ErrorState.Value" ErrorId="@ErrorIdState.Value"
Clearable="@Clearable" OnClearButtonClick="(async (e) => await SelectClearButtonClickHandlerAsync(e))"
Clearable="@(Clearable && !GetReadOnlyState())" OnClearButtonClick="(async (e) => await SelectClearButtonClickHandlerAsync(e))"
@attributes="UserAttributes" OnBlur="@OnLostFocus" ShrinkLabel="@(AdornmentStart != null || ShrinkLabel)" Typo="@Typo"
ShowVisualiser="true" DataVisualiserStyle="min-height: 1.1876em; padding-right: 0px;">

Expand Down
2 changes: 1 addition & 1 deletion src/CodeBeam.MudBlazor.Extensions/Components/TextFieldExtended/MudTextFieldExtended.razor
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@
KeyDownPreventDefault="KeyDownPreventDefault"
KeyUpPreventDefault="KeyUpPreventDefault"
HideSpinButtons="true"
Clearable="@Clearable"
Clearable="@ShowClearButton()"
OnClearButtonClick="@OnClearButtonClick"
Pattern="@Pattern"
AutoSize="AutoSize"
Expand Down
6 changes: 6 additions & 0 deletions src/CodeBeam.MudBlazor.Extensions/Components/TextFieldExtended/MudTextFieldExtended.razor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,6 +217,12 @@ public IMask? Mask
// return base.SetTextAsync(text, updateValue);
//}

private bool ShowClearButton()
{
if (SubscribeToParentForm)
return Clearable && !GetReadOnlyState() && !GetDisabledState();
return Clearable && !GetDisabledState();
}
private async Task OnMaskedValueChanged(string s)
{
await SetTextAndUpdateValueAsync(s, false);
Expand Down
Loading