Skip to content

fix: optionality handling in zodv4 Properties type #1521

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Dqu1J wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: optionality handling in zodv4 Properties type #1521

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/zodv4/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,15 @@ import type {
UnionTypeDefinitionNode,
} from 'graphql';

import type { ValidationSchemaPluginConfig } from '../config.js';
import type { Visitor } from '../visitor.js';
import { DeclarationBlock, indent } from '@graphql-codegen/visitor-plugin-common';
import { Kind } from 'graphql';
import type { ValidationSchemaPluginConfig } from '../config.js';
import {
InterfaceTypeDefinitionBuilder,
ObjectTypeDefinitionBuilder,
} from '../graphql.js';
import { BaseSchemaVisitor } from '../schema_visitor.js';
import type { Visitor } from '../visitor.js';
import { buildZodOperationSchemas } from '../zod/operation.js';
import {
anySchema,
Expand Down Expand Up @@ -51,7 +51,7 @@ export class ZodV4SchemaVisitor extends BaseSchemaVisitor {
new DeclarationBlock({})
.asKind('type')
.withName('Properties<T>')
.withContent(['{', ' [K in keyof T]: z.ZodType<T[K], T[K] | undefined>;', '}'].join('\n'))
.withContent(['Required<{', ' [K in keyof T]: undefined extends T[K]', ' ? z.ZodType<T[K]> & { _zod: { optout: "optional" } }', ' : z.ZodType<T[K]>', '}>'].join('\n'))
.string,
// Unfortunately, zod doesn’t provide non-null defined any schema.
// This is a temporary hack until it is fixed.
Expand Down
Loading