Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #195
📝 Description
Backend changes:
I realized during development that the single order updating was deprecated, as we needed a way to update the tracking link and shipping cost for all of the orders at once. Therefore, I added a new endpoint and service function (as well as tests) for this, and got rid of the old one. The backend now takes in ether the shipping cost or tracking link for each order from the donation, and updates the order to shipped when both are provided eventually. Additionally, I also realized now that we would need to make it so that we can edit fields for confirming a donation item, even after it gets confirmed. I modularized the old confirm donation item details endpoint to accept all fields as optional, and rather just serve as an update function that, in the even where all fields got values, we would make it so the details became confimred.
Frontend changes:
I made the frontend page, with a few minor adjustments agreed upon with design:
✔️ Verification
Screenshots of pages:



🏕️ (Optional) Future Work / Notes
N/A