Open
Conversation
amywng
requested changes
Apr 26, 2026
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
could you also add a test that the transaction manager doesn't apply any changes if an error/exception is thrown during the transaction?
| `SELECT reserved_quantity FROM donation_items WHERE item_id = $1`, | ||
| [itemId], | ||
| ); | ||
| expect(Number(reserved_quantity)).toBe(33); |
Member
There was a problem hiding this comment.
can you add a check that the reserved quantity is 30 before
| `SELECT reserved_quantity FROM donation_items WHERE item_id = $1`, | ||
| [itemId2], | ||
| ); | ||
| expect(Number(item1.reserved_quantity)).toBe(35); |
| expect(Number(item2.reserved_quantity)).toBe(22); | ||
| }); | ||
|
|
||
| it('should throw BadRequestException for orderId of 0', async () => { |
Member
There was a problem hiding this comment.
i think we said we don't need these since we alr test the validate function elsewhere (this test and the two below)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?jql=assignee%20%3D%20712020%3A10ef9ad9-e290-4bbd-8c4b-cb215e8d449a&selectedIssue=SSF-197
📝 Description
Removed allocations controller and added service.spec file with tests for service functions.
✔️ Verification
Added tests and made sure they passed
🏕️ (Optional) Future Work / Notes
N/A