Skip to content

[SSF-196] update date picker to use chakra#160

Merged
amywng merged 6 commits intomainfrom
acw/SSF-196-pantry-orders-date-picker
Apr 25, 2026
Merged

[SSF-196] update date picker to use chakra#160
amywng merged 6 commits intomainfrom
acw/SSF-196-pantry-orders-date-picker

Conversation

@amywng
Copy link
Copy Markdown
Member

@amywng amywng commented Apr 20, 2026

ℹ️ Issue

Closes SSF-196

📝 Description

✔️ Verification

frontend verification
Screenshot 2026-04-19 at 10 34 04 PM

Copy link
Copy Markdown
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing a really weird thing on this branch (confirmed main is fine) where whenever I click any of the links in any of the tables on any of the pages (to open a modal / etc.) and then close it, I can no longer click anything on the page without refreshing. guessing this must've somehow been caused by the chakra update (sorry)... could you look into this?

@dburkhart07 dburkhart07 self-requested a review April 22, 2026 22:52
@amywng
Copy link
Copy Markdown
Member Author

amywng commented Apr 23, 2026

tbh i tried everything and the only way seems to be either setting modal={false} for all the Dialog's (which I think causes more impact than the solution I ended up with) or just manually resetting the html tags

@amywng amywng requested a review from sam-schu April 23, 2026 01:27
Copy link
Copy Markdown
Collaborator

@sam-schu sam-schu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if you could click anywhere in the date received input box and it would open up the date picker, rather than turning into a very confusing numeric input.

very annoying with chakra, I trust there's no better way to fix that. chakra update very ssf 🙃

Comment thread apps/frontend/src/hooks/modalBodyCleanup.ts
Copy link
Copy Markdown

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things 🐶 ⏲️ 🔒 👎

Comment thread apps/frontend/src/components/forms/orderReceivedActionModal.tsx
Comment thread apps/frontend/src/components/forms/orderReceivedActionModal.tsx
Comment thread apps/frontend/src/components/forms/orderReceivedActionModal.tsx Outdated
Comment thread apps/frontend/src/components/forms/orderReceivedActionModal.tsx Outdated
Comment thread apps/frontend/src/chakra-ui.d.ts Outdated
Comment thread apps/frontend/src/components/forms/orderReceivedActionModal.tsx
@amywng amywng requested a review from dburkhart07 April 25, 2026 13:57
Copy link
Copy Markdown

@dburkhart07 dburkhart07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!! last chakra version upgrade youll ever have to do, very sad day for us all 🥲 🐈‍⬛

@amywng amywng merged commit 2f699bb into main Apr 25, 2026
4 checks passed
@amywng amywng deleted the acw/SSF-196-pantry-orders-date-picker branch April 25, 2026 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants