Conversation
| describe('POST /create', () => { | ||
| it('should call requestsService.create and return the created food request', async () => { | ||
| const createBody: Partial<FoodRequest> = { | ||
| const createBody = { |
There was a problem hiding this comment.
Is the cast necessary here or can we just type this object normally?
There was a problem hiding this comment.
In reply to this, I think this cast is necessary. Even if we are typing the object normally, now this has no type.
| "compilerOptions": { | ||
| "esModuleInterop": true | ||
| "esModuleInterop": true, | ||
| "strict": true |
There was a problem hiding this comment.
very epic and awesome line of code right here that I am very excited for !!
There was a problem hiding this comment.
I don't see any package.json changes?
There was a problem hiding this comment.
@Juwang110 How come we have changes to the yarn lock but not the package.json?
There was a problem hiding this comment.
Sorry, not sure, will look into that
apps/backend/src/donationItems/dtos/create-donation-items.dto.ts
Outdated
Show resolved
Hide resolved
|
Gonna wait on Sam's approval before I do a final review I think! |
sam-schu
left a comment
sam-schu
left a comment
There was a problem hiding this comment.
lgtm!!
STRICT MODEEEEEEEEEEEEE
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Few questions and inconsistencies that need to be cleared up.
Also, can we change I realized I should've made this a DTO but thought it would be good to do here. Can we take the SendEmailDTO in types.ts in the emails directory, put it in a DTO folder, and change the 2 max lengths to be Lenght(1, 255)
| allocationId: number; | ||
| allocationId!: number; | ||
|
|
||
| @Column({ name: 'order_id', type: 'int', nullable: false }) |
There was a problem hiding this comment.
Why do we have nullable: false for a required field? This seems inconsistent, and something I'd imagine we would put for all required fields, or no required fields (theres many others throughout this entity and other ones that do not have a nullable property anywhere).
There was a problem hiding this comment.
I think the default is nullable: false unless nullable: true is specified. So specifying nullable: false is the same as essentially not typing anything.
There was a problem hiding this comment.
maybe im missing something, but why cant we just delete it then? right now it seems inconsistently used throughout our join tables within entities, as well as entity id fields.
There was a problem hiding this comment.
as a note, nullable: true is the default for relationships in entities, so i left those but deleted all uneccessary instances of nullable: false
| describe('POST /create', () => { | ||
| it('should call requestsService.create and return the created food request', async () => { | ||
| const createBody: Partial<FoodRequest> = { | ||
| const createBody = { |
There was a problem hiding this comment.
In reply to this, I think this cast is necessary. Even if we are typing the object normally, now this has no type.
dburkhart07
left a comment
dburkhart07
left a comment
There was a problem hiding this comment.
Just a few more small things. I know there's a big merge conflict that needs to be resolved, but hopefully after that it should be good.
4 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-131 and
https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-138
📝 Description
This PR enables typescript strict mode in the backend which enables the compiler to be a lot more picky and strict with types, null and undefined checks, etc. The PR includes changes to make our backend adhere with all the rules that strict mode enforces. This involved work making entity fields optional or required, and also handling null/undefined errors and return values.
✔️ Verification
I made sure all the backend tests pass and npx nx serve backend properly runs without error.
🏕️ (Optional) Future Work / Notes
N/A