forked from Code-4-Community/scaffolding
-
Notifications
You must be signed in to change notification settings - Fork 0
SSF-124 Replacing Browser Alerts #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Juwang110
wants to merge
20
commits into
main
Choose a base branch
from
jw/SSF-124-replacing-native-alerts
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f2cfd05
replacing native alerts with chakra ui alerts
Juwang110 1e22db5
changing positioning to fixed
Juwang110 28299f2
prettier
Juwang110 8fa41bc
abstracting floating alert to its own component
Juwang110 b223b60
prettier
Juwang110 6e41190
padding for alert
Juwang110 164f8a6
Merge branch 'main' into jw/SSF-124-replacing-native-alerts
Juwang110 d276142
removing console.log
Juwang110 0037f6c
Merge branch 'main' into jw/SSF-124-replacing-native-alerts
Juwang110 712de54
making voluntter management use floating alert and comments
Juwang110 ab27bf1
minor refactoring and prettier
Juwang110 67f1092
Merge branch 'main' into jw/SSF-124-replacing-native-alerts
Juwang110 09da200
refactoring
Juwang110 3a7ff94
up to date with main and conflicts solved
Juwang110 6b4c831
adding new alert to login flow
Juwang110 810d482
Merge branch 'main' into jw/SSF-124-replacing-native-alerts
Juwang110 61e39a8
adding alert for request submission success
Juwang110 c8dac45
combining state
Juwang110 12b554e
prettier
Juwang110 bd0005c
Merge branch 'main' into jw/SSF-124-replacing-native-alerts
Juwang110 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| import { Alert } from '@chakra-ui/react'; | ||
| import { useEffect, useState } from 'react'; | ||
|
|
||
| type FloatingAlertProps = { | ||
| message?: string | null; | ||
| status?: 'info' | 'error'; | ||
| timeout?: number; | ||
| }; | ||
|
|
||
| export function FloatingAlert({ | ||
| message, | ||
| status, | ||
| timeout, | ||
| }: FloatingAlertProps) { | ||
| const [visible, setVisible] = useState(!!message); | ||
|
|
||
| useEffect(() => { | ||
| if (!message) { | ||
| setVisible(false); | ||
| return; | ||
| } | ||
|
|
||
| setVisible(true); | ||
|
|
||
| if (!timeout) return; | ||
|
|
||
| const timer = setTimeout(() => { | ||
| setVisible(false); | ||
| }, timeout); | ||
|
|
||
| return () => clearTimeout(timer); | ||
| }, [message, timeout]); | ||
|
|
||
| if (!message || !visible) return null; | ||
|
|
||
| return ( | ||
| <Alert.Root | ||
| color={status === 'info' ? 'neutral.800' : 'red'} | ||
| status="info" | ||
| bg="white" | ||
| variant="subtle" | ||
| boxShadow="lg" | ||
| position="fixed" | ||
| zIndex="toast" | ||
| top="12px" | ||
| right="12px" | ||
| w="fit-content" | ||
| maxW="400px" | ||
| p={2} | ||
| > | ||
| <Alert.Indicator /> | ||
| <Alert.Title textStyle="p2" fontWeight={500}> | ||
| {message} | ||
| </Alert.Title> | ||
| </Alert.Root> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could we add a success alert here similar to the food request submission one you just added?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since on success it instantly navigates to /login I don't think a success alert is necessary, itll alert on failure or navigate on success.