#127 - harden SES email feature: auth, plain-text, logging#132
Open
piersolh wants to merge 2 commits into
Open
#127 - harden SES email feature: auth, plain-text, logging#132piersolh wants to merge 2 commits into
piersolh wants to merge 2 commits into
Conversation
- Re-enable AuthGuard('jwt') on all bulk-send and template management endpoints
- Attach plain-text alternative to every email (multipart/alternative) for deliverability
- Add per-recipient send + failure logging for bulk campaigns; surface failed count
- Wrap donation-response template variable replacement in try/catch with raw-template fallback
- Only render https-hosted signature images (drop local PNG import) so images aren't referenced locally
piersolh
commented
Jun 15, 2026
|
|
||
| return ( | ||
| html | ||
| // Drop content of non-visible elements entirely. |
Contributor
Author
There was a problem hiding this comment.
this is really excessive commenting but I thought it might be helpful cause regex's are so hard to read
piersolh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
NOTE: emails still go to spam because I am using my personal email as the SES email. we need to use a verified email to stop getting hit with gmail's spam filter.
Re-enables auth on the email endpoints, adds plain-text alternatives and per-recipient bulk failure logging for deliverability, guards template variable replacement, and stops referencing images locally.
Changes Made
Details:
@UseGuards(AuthGuard('jwt'))on all bulk-send and template-management endpoints (send-email,templateGET/POST,subscribers,bulk-send)text/plainalternative to every email (multipart/alternative) via a lightweighthtmlToPlainTextutilTo, and the response surfaces afailedcount.https://-hosted images (local PNG import removed) so images resolve in recipients' inboxes.Testing & Verification
Verification Steps:
Future Improvements/Notes
buildFullHTML, (2) a publicGET /emails/unsubscribeendpoint flippingisSubscribed/unsubscribedAt(columns already exist), and optionally (3) aList-Unsubscribeheader for bulk deliverability. Being handled separately.Related Issues
Closes #127