105 Add Authentication Check to Projects Routes#140
Open
Conversation
nourshoreibah
requested changes
Feb 22, 2026
Collaborator
nourshoreibah
left a comment
nourshoreibah
left a comment
There was a problem hiding this comment.
Just a question and a comment on permissions. Thank you and good work!
| } | ||
|
|
||
| const authContext = await authenticateRequest(event); | ||
| if (!authContext.isAuthenticated || !authContext.user) { |
Collaborator
There was a problem hiding this comment.
This is the right idea, but we actually want to do this in a more fine grained way.
For PUT project, user should be admin (only admin can create a project)
For the GET, the user should just be anyone authenticated
Also, looks like CI is failing because aws-jwt-verify is not installed, should just be able to npm install this
| } | ||
|
|
||
| export interface BranchUsers { | ||
| cognito_sub: string | null; |
Collaborator
There was a problem hiding this comment.
wait omg never mind idk why i thought it was sql. ignore this comment
| } | ||
|
|
||
| export interface BranchUsers { | ||
| cognito_sub: string | null; |
Collaborator
There was a problem hiding this comment.
wait omg never mind idk why i thought it was sql. ignore this comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #105
📝 Description
Added authentication to the projects lambda to protect its endpoints from unauthorized access. Without this, anyone with the URL could read or create projects once the lambda is made public.
Briefly list the changes made to the code:
✔️ Verification
Clone the branch and run npx jest from apps/backend/lambdas/projects
All tests should pass without a running Cognito instance since auth is mocked