Skip to content

Bug fix test settings jsx#432

Closed
janekamata wants to merge 77 commits intomainfrom
bug-fix-test-settings-jsx
Closed

Bug fix test settings jsx#432
janekamata wants to merge 77 commits intomainfrom
bug-fix-test-settings-jsx

Conversation

@janekamata
Copy link
Copy Markdown
Contributor

@janekamata janekamata commented Apr 18, 2026

ℹ️ Issue

Closes

📝 Description

Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.

Briefly list the changes made to the code:

  1. Added support for this.
  2. And removed redunant use of that.
  3. Also this was included for reasons.

✔️ Verification

What steps did you take to verify your changes work? These should be clear enough for someone to be able to clone the branch and follow the steps themselves.

Provide screenshots of any new components, styling changes, or pages.

Test Changes

If your new feature required some test to be changed or added to fit the new functionality or changes please document these changes here.

🏕️ (Optional) Future Work / Notes

Did you notice anything ugly during the course of this ticket? Any bugs, design challenges, or unexpected behavior? Write it down so we can clean it up in a future ticket!

janekamata and others added 30 commits April 14, 2026 01:18
@janekamata
Adding new field to types
de8fa47
@janekamata
Updating add/edit cost for interval
5baa09b
@janekamata
Cashflow cards styling
191212f
@janekamata
Styling changes
28a289a
@janekamata
Initial ts script
01788ae
@janekamata
Working on chart
c8b5b6d
@janekamata
Styling and empty state
5c93faa
@janekamata
Changing title name
f7e9a61
@janekamata
Spacing fix
9df9895
@janekamata
Squashed commit of the following:
1af815b 
commit bd40505
Merge: 928ad1f e08b3fd
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Tue Apr 14 18:46:04 2026 -0400

    Merge pull request #414 from Code-4-Community/backgroundFix

    background fix

commit e08b3fd
Merge: 6ca3482 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:24:48 2026 -0400

    Merge branch 'main' into backgroundFix

commit 6ca3482
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 17:22:07 2026 -0400

    removed media query

commit 36c4cb3
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 13:59:18 2026 -0400

    background fix
@janekamata
Squashed commit of the following:
67f240e 
commit bba66a7
Author: lyannne <xu.ly@northeastern.edu>
Date:   Mon Apr 13 22:57:15 2026 -0400

    resolving copilot comments

commit 3eb6ad3
Author: Lyanne Xu <xu.ly@northeastern.edu>
Date:   Mon Apr 13 22:18:52 2026 -0400

    add revenue and cost to clear all filters

    Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

commit 5236917
Author: Lyanne Xu <xu.ly@northeastern.edu>
Date:   Mon Apr 13 22:17:14 2026 -0400

    stronger typing for multi select status filter

    Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

commit 8becfe9
Author: lyannne <xu.ly@northeastern.edu>
Date:   Mon Apr 13 21:46:28 2026 -0400

    same button behavior for grant page filters and categoryfilter

commit d1bc108
Merge: 46efaf0 928ad1f
Author: lyannne <xu.ly@northeastern.edu>
Date:   Mon Apr 13 21:45:07 2026 -0400

    Merge remote-tracking branch 'origin/main' into surprise-ben-filtering-for-cashflow

commit 46efaf0
Author: lyannne <xu.ly@northeastern.edu>
Date:   Mon Apr 13 21:38:06 2026 -0400

    custom checkbox field to match design, edits made to cashcategorydropdwon to match design, misc css changes

commit 9b351c0
Author: lyannne <xu.ly@northeastern.edu>
Date:   Mon Apr 13 17:36:59 2026 -0400

    grant sttaus and cashflow revenues and costs have multiselect filter, edited dropdown to match design, misc. css fixes
@janekamata
Squashed commit of the following:
2c9e838 
commit bcd9be1
Merge: e35be06 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:26:17 2026 -0400

    Merge branch 'main' into no-editing-grant-revenue

commit e35be06
Author: lyannne <xu.ly@northeastern.edu>
Date:   Sun Apr 12 19:48:11 2026 -0400

    resolved copilot comments

commit b12d786
Merge: 77705e0 2202e50
Author: Lyanne Xu <xu.ly@northeastern.edu>
Date:   Sun Apr 12 19:36:12 2026 -0400

    Merge branch 'main' into no-editing-grant-revenue

commit 77705e0
Author: lyannne <xu.ly@northeastern.edu>
Date:   Sun Apr 12 19:20:53 2026 -0400

    commented out check i think isnt useful with comment for reasoning

commit 82e50b4
Author: lyannne <xu.ly@northeastern.edu>
Date:   Sun Apr 12 18:26:52 2026 -0400

    specified backend type

commit 38feb5f
Author: lyannne <xu.ly@northeastern.edu>
Date:   Sun Apr 12 18:11:01 2026 -0400

    open in grants button

commit 46168d2
Author: lyannne <xu.ly@northeastern.edu>
Date:   Sun Apr 12 17:22:45 2026 -0400

    grant page grants are displayed and not editable

commit db54046
Author: lyannne <xu.ly@northeastern.edu>
Date:   Sun Apr 12 17:01:08 2026 -0400

    backend guard for editing grant page grant as a revenue

commit c73cd06
Merge: 08a77c8 bb4fe01
Author: lyannne <xu.ly@northeastern.edu>
Date:   Sun Apr 12 16:52:20 2026 -0400

    Merge remote-tracking branch 'origin/392/add-active-grants-to-revenue-list' into no-editing-grant-revenue

commit bb4fe01
Author: Yumiko (Yumi) Chow <75456756+yumi520@users.noreply.github.com>
Date:   Sun Apr 12 14:19:22 2026 -0400

    fixed test to only scan revenue

commit 93a0f9c
Author: Yumiko (Yumi) Chow <75456756+yumi520@users.noreply.github.com>
Date:   Sun Apr 12 14:06:00 2026 -0400

    moved logic to frontend

commit 6b0bafe
Author: Yumiko (Yumi) Chow <75456756+yumi520@users.noreply.github.com>
Date:   Thu Apr 9 19:52:03 2026 -0400

    mapped grants to revenue row
@janekamata
Squashed commit of the following:
860ce6c 
commit b494ab9
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Tue Apr 14 19:50:34 2026 -0400

    Styling fixes (#425)

commit bd40505
Merge: 928ad1f e08b3fd
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Tue Apr 14 18:46:04 2026 -0400

    Merge pull request #414 from Code-4-Community/backgroundFix

    background fix

commit e08b3fd
Merge: 6ca3482 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:24:48 2026 -0400

    Merge branch 'main' into backgroundFix

commit 6ca3482
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 17:22:07 2026 -0400

    removed media query

commit 36c4cb3
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 13:59:18 2026 -0400

    background fix
@janekamata
Squashed commit of the following:
2a61506 
commit 01e8849
Author: Yumiko (Yumi) Chow <75456756+yumi520@users.noreply.github.com>
Date:   Sun Apr 12 17:38:19 2026 -0400

    unified revenue add and edit
@janekamata
When you click on item it goes to grant
99f709f
@janekamata
Date filter and formatting
c54dc73
@janekamata
Default date, resolving frontend errors from console
4856057
@janekamata
Updating kpis and projection date filters
06f5d09
@janekamata
Saving cashflow settings on page change
f386445
@janekamata
Merge branch 'main' into 412-dev---update-cashflow-chart-with-live-co…
dc308e8 
…st-and-revenue-data-add-custom-costrevenue-interval
@janekamata
Updating tests
3c93093
@janekamata
Fixing test
14aa287
@janekamata
Removing use effect
17cd6b0
@janekamata
Fixing empty settings
68cae25
@janekamata
Fixing nan settings save
75a97b9
@janekamata
Formatting
a1e0bb1
@janekamata
Styling
76644ba
@janekamata
Removing unused imports
24e541e
@janekamata
Fixing duplicate revenue name on edit allowed
8317846
@lyannne
clear all to multi-select status, added lg breakpoint
ce509b7
janekamata and others added 28 commits April 16, 2026 23:02
@janekamata
Removing mock return value
8d681bf
@janekamata
Styling fixes and adding more disabled buttons to sign up and login
ebaed3c
@janekamata
Squashed commit of the following:
b5a5a73 
commit e604a40
Merge: 5e66036 e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Thu Apr 16 21:36:56 2026 -0400

    Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects

    update user profile updates side effects

commit 5e66036
Merge: 8dec21b fefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 18:09:59 2026 -0400

    Merge pull request #429 from Code-4-Community/bug-fix-filters

    Fixing filters bug

commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Wed Apr 15 14:15:50 2026 -0400

    Fixing filters bug

commit e7803ec
Merge: e68bab4 8dec21b
Author: prooflesben <prooflesben@gmail.com>
Date:   Wed Apr 15 13:26:37 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit 8dec21b
Merge: 6490d98 5d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 12:53:24 2026 -0400

    Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well

    update delete grant so it deletes notifs too

commit e68bab4
Merge: 1f208b2 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:22:05 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 18:31:57 2026 -0400

    fixed code and tests

commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 17:46:42 2026 -0400

    update user profile updates side effects

commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 20:17:31 2026 -0400

    updated tests

commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 19:29:31 2026 -0400

    update delete grant so it deletes notifs too
@janekamata
Settings disabled button
bcaf420
@janekamata
Styling fixes
f2b1071
@janekamata
Adding keys
8d44913
@janekamata
Making contact card observable
2b65282
@janekamata
Saving button text cost/revenue
c5f38fa
@janekamata
Settings is submitting
f57c509
@janekamata
Fixing cashflow settings save error for nonadmin
0551aba
@janekamata
Squashed commit of the following:
d774cec 
commit 2f0ce91
Merge: e604a40 847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Fri Apr 17 15:38:12 2026 -0400

    Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations

    Adding Action Confirmations

commit 847520a
Merge: b3be17b e604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Thu Apr 16 21:58:52 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date:   Thu Apr 16 21:42:44 2026 -0400

    white background

commit e604a40
Merge: 5e66036 e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Thu Apr 16 21:36:56 2026 -0400

    Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects

    update user profile updates side effects

commit ceaadd4
Merge: b2fabd4 5e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Wed Apr 15 22:26:16 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit 5e66036
Merge: 8dec21b fefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 18:09:59 2026 -0400

    Merge pull request #429 from Code-4-Community/bug-fix-filters

    Fixing filters bug

commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Wed Apr 15 14:15:50 2026 -0400

    Fixing filters bug

commit e7803ec
Merge: e68bab4 8dec21b
Author: prooflesben <prooflesben@gmail.com>
Date:   Wed Apr 15 13:26:37 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit 8dec21b
Merge: 6490d98 5d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 12:53:24 2026 -0400

    Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well

    update delete grant so it deletes notifs too

commit e68bab4
Merge: 1f208b2 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:22:05 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit b2fabd4
Merge: e2779c8 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:21:20 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit e2779c8
Merge: 28ebeba 2202e50
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:50:23 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations

commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:43:34 2026 -0400

    action confirmations for everything and adding in colors

commit 3acea04
Merge: ff6e87e 08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:24:02 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations

commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 18:31:57 2026 -0400

    fixed code and tests

commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 17:46:42 2026 -0400

    update user profile updates side effects

commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date:   Thu Apr 9 15:15:43 2026 -0400

    confirmation for needed actions

commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 20:17:31 2026 -0400

    updated tests

commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 19:29:31 2026 -0400

    update delete grant so it deletes notifs too
@janekamata
Edit revenue confirmation fix
33f49c0
@janekamata
Adding back lyanne fixes
c65e9dc
@janekamata
Squashed commit of the following:
3c9bfeb 
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Sat Apr 18 00:34:03 2026 -0400

    changed colors and added missing confirmations (#431)

    * changed colors and added missing confirmations

    * Styling fixes

    * prioritize adding errors over action confirmation modal

    * Updating yellow

    ---------

    Co-authored-by: Jane Kamata <janekamata8@gmail.com>
    Co-authored-by: lyannne <xu.ly@northeastern.edu>

commit 2f0ce91
Merge: e604a40 847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Fri Apr 17 15:38:12 2026 -0400

    Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations

    Adding Action Confirmations

commit 847520a
Merge: b3be17b e604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Thu Apr 16 21:58:52 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date:   Thu Apr 16 21:42:44 2026 -0400

    white background

commit e604a40
Merge: 5e66036 e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Thu Apr 16 21:36:56 2026 -0400

    Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects

    update user profile updates side effects

commit ceaadd4
Merge: b2fabd4 5e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Wed Apr 15 22:26:16 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit 5e66036
Merge: 8dec21b fefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 18:09:59 2026 -0400

    Merge pull request #429 from Code-4-Community/bug-fix-filters

    Fixing filters bug

commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Wed Apr 15 14:15:50 2026 -0400

    Fixing filters bug

commit e7803ec
Merge: e68bab4 8dec21b
Author: prooflesben <prooflesben@gmail.com>
Date:   Wed Apr 15 13:26:37 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit 8dec21b
Merge: 6490d98 5d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 12:53:24 2026 -0400

    Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well

    update delete grant so it deletes notifs too

commit e68bab4
Merge: 1f208b2 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:22:05 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit b2fabd4
Merge: e2779c8 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:21:20 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit e2779c8
Merge: 28ebeba 2202e50
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:50:23 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations

commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:43:34 2026 -0400

    action confirmations for everything and adding in colors

commit 3acea04
Merge: ff6e87e 08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:24:02 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations

commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 18:31:57 2026 -0400

    fixed code and tests

commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 17:46:42 2026 -0400

    update user profile updates side effects

commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date:   Thu Apr 9 15:15:43 2026 -0400

    confirmation for needed actions

commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 20:17:31 2026 -0400

    updated tests

commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 19:29:31 2026 -0400

    update delete grant so it deletes notifs too
@janekamata
Fixing revenue errors
9a98840
@janekamata
Merge branch 'main' into 412-dev---update-cashflow-chart-with-live-co…
deee89b 
…st-and-revenue-data-add-custom-costrevenue-interval
@janekamata
Edit revenue confirmation
ec7e8c8
@janekamata
Fixing errors
dd85778
@janekamata
Fixing navbar
9413b77
@janekamata
Fixing edit cost errors
ca37771
@janekamata
Deleting duplicate popup
6c00231
@janekamata
Confirmation styling
64791f0
@janekamata
Moving generating ticks log
660804a
@prooflesben
some small refresh things were incorrect and removed frontend referen…
76cd98d 
…ces to an access token which should only be in th cookies
@prooflesben
Fixed a small error relating to deleting access token references
17078df
@prooflesben
dumb change
5fcd89a
@janekamata
Remaking settings and organizing components
9a42275
@janekamata
Updating test
08c9e5e
@janekamata janekamata closed this Apr 18, 2026
@janekamata janekamata deleted the bug-fix-test-settings-jsx branch April 18, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@janekamata @lyannne @prooflesben