Skip to content

changed colors and added missing confirmations#431

Merged
janekamata merged 4 commits intomainfrom
ConfirmationFixes
Apr 18, 2026
Merged

changed colors and added missing confirmations#431
janekamata merged 4 commits intomainfrom
ConfirmationFixes

Conversation

@adityapat24
Copy link
Copy Markdown
Contributor

@adityapat24 adityapat24 commented Apr 17, 2026

fixed coloring based on designer feedback for action confirmation
added action confirmation for adding and editing cost

image image image image image

@adityapat24 adityapat24 requested a review from prooflesben April 17, 2026 20:41
janekamata
janekamata approved these changes Apr 18, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@janekamata janekamata left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed a styling fix; lgtm, will go ahead and merge so I can resolve conflicts with cashflow; Lyanne also looked over

@janekamata janekamata merged commit 5a9c130 into main Apr 18, 2026
1 check passed
janekamata added a commit that referenced this pull request Apr 18, 2026
@janekamata
Squashed commit of the following:
3c9bfeb 
commit 5a9c130
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Sat Apr 18 00:34:03 2026 -0400

    changed colors and added missing confirmations (#431)

    * changed colors and added missing confirmations

    * Styling fixes

    * prioritize adding errors over action confirmation modal

    * Updating yellow

    ---------

    Co-authored-by: Jane Kamata <janekamata8@gmail.com>
    Co-authored-by: lyannne <xu.ly@northeastern.edu>

commit 2f0ce91
Merge: e604a40 847520a
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Fri Apr 17 15:38:12 2026 -0400

    Merge pull request #400 from Code-4-Community/397-dev-adding-more-action-confirmations

    Adding Action Confirmations

commit 847520a
Merge: b3be17b e604a40
Author: Aditya Pathak <138696171+adityapat24@users.noreply.github.com>
Date:   Thu Apr 16 21:58:52 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit b3be17b
Author: lyannne <xu.ly@northeastern.edu>
Date:   Thu Apr 16 21:42:44 2026 -0400

    white background

commit e604a40
Merge: 5e66036 e7803ec
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Thu Apr 16 21:36:56 2026 -0400

    Merge pull request #401 from Code-4-Community/396-dev-user-profile-updates-side-effects

    update user profile updates side effects

commit ceaadd4
Merge: b2fabd4 5e66036
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Wed Apr 15 22:26:16 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit 5e66036
Merge: 8dec21b fefdad9
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 18:09:59 2026 -0400

    Merge pull request #429 from Code-4-Community/bug-fix-filters

    Fixing filters bug

commit fefdad9
Author: Jane Kamata <janekamata8@gmail.com>
Date:   Wed Apr 15 14:15:50 2026 -0400

    Fixing filters bug

commit e7803ec
Merge: e68bab4 8dec21b
Author: prooflesben <prooflesben@gmail.com>
Date:   Wed Apr 15 13:26:37 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit 8dec21b
Merge: 6490d98 5d56537
Author: prooflesben <122566738+prooflesben@users.noreply.github.com>
Date:   Wed Apr 15 12:53:24 2026 -0400

    Merge pull request #391 from Code-4-Community/382-dev---update-delete-grant-so-it-notifications-as-well

    update delete grant so it deletes notifs too

commit e68bab4
Merge: 1f208b2 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:22:05 2026 -0400

    Merge branch 'main' into 396-dev-user-profile-updates-side-effects

commit b2fabd4
Merge: e2779c8 10fb2cd
Author: Jane Kamata <38163243+janekamata@users.noreply.github.com>
Date:   Mon Apr 13 13:21:20 2026 -0400

    Merge branch 'main' into 397-dev-adding-more-action-confirmations

commit e2779c8
Merge: 28ebeba 2202e50
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:50:23 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations

commit 28ebeba
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:43:34 2026 -0400

    action confirmations for everything and adding in colors

commit 3acea04
Merge: ff6e87e 08a77c8
Author: adityapat24 <appathak46@gmail.com>
Date:   Sun Apr 12 16:24:02 2026 -0400

    Merge branch 'main' of https://github.com/Code-4-Community/bcan into 397-dev-adding-more-action-confirmations

commit 1f208b2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 18:31:57 2026 -0400

    fixed code and tests

commit 710a756
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Thu Apr 9 17:46:42 2026 -0400

    update user profile updates side effects

commit ff6e87e
Author: adityapat24 <appathak46@gmail.com>
Date:   Thu Apr 9 15:15:43 2026 -0400

    confirmation for needed actions

commit 5d56537
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 20:17:31 2026 -0400

    updated tests

commit ba316f2
Author: Camila Carrillo <carrillo.ca@northeastern.edu>
Date:   Fri Apr 3 19:29:31 2026 -0400

    update delete grant so it deletes notifs too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janekamata janekamata janekamata approved these changes

@prooflesben prooflesben Awaiting requested review from prooflesben

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adityapat24 @janekamata @lyannne