Skip to content

Change handshake spec to be simpler #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukemarsden wants to merge 1 commit into
base: plugin_mode
Choose a base branch
from
Open

Change handshake spec to be simpler #14

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions plugins/plugin.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,7 @@ type Plugin struct {
}

type handshakeResp struct {
InterestedIn []string
Name string
Author string
Org string
Website string
Implements []string
}

func (p *Plugin) Call(method, path string, data interface{}) (io.ReadCloser, error) {
Expand Down
2 changes: 1 addition & 1 deletion plugins/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ func (repository *Repository) RegisterPlugin(addr string) error {
return fmt.Errorf("error in plugin handshake: %v", err)
}

for _, interest := range resp.InterestedIn {
for _, interest := range resp.Implements {
if _, exists := supportedPluginTypes[interest]; !exists {
return fmt.Errorf("plugin type %s is not supported", interest)
}
Expand Down