fix: performance issues due to missing mc packet logging filter#1860
Open
fix: performance issues due to missing mc packet logging filter#1860
Conversation
There was a problem hiding this comment.
Pull request overview
This PR addresses wrapper performance degradation caused by excessive Minecraft network packet logging when running with Logback (which bypasses Log4j filter configuration).
Changes:
- Added a Logback
MarkerFilterturbo filter to deny log events marked asNETWORK_PACKETS(configurable via properties). - Added the required
MarkerFilterimport tologback.xml.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Test Results 56 files ±0 56 suites ±0 4m 20s ⏱️ -22s Results for commit 44caf1c. ± Comparison against base commit 67b9e0a. This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Our logback instance replaces log4j implementations and thus also filters that might be defined in log4j configs.
Modification
Copied the mc packet filter to our logback config to ensure proper filtering of network packets.
Result
Performance issues due to massive logging resolved