Skip to content

fix: performance issues due to missing mc packet logging filter#1860

Open
0utplay wants to merge 2 commits intonightlyfrom
fix/logback-packet-spam
Open

fix: performance issues due to missing mc packet logging filter#1860
0utplay wants to merge 2 commits intonightlyfrom
fix/logback-packet-spam

Conversation

@0utplay
Copy link
Copy Markdown
Member

@0utplay 0utplay commented Apr 27, 2026

Motivation

Our logback instance replaces log4j implementations and thus also filters that might be defined in log4j configs.

Modification

Copied the mc packet filter to our logback config to ensure proper filtering of network packets.

Result

Performance issues due to massive logging resolved

@0utplay 0utplay requested a review from Copilot April 27, 2026 20:35
@0utplay 0utplay self-assigned this Apr 27, 2026
@0utplay 0utplay added v: 4.X This pull should be included in the 4.0 release t: fix A pull request introducing a fix for a bug. in: wrapper An issue/pull request releated to the wrapper module code labels Apr 27, 2026
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses wrapper performance degradation caused by excessive Minecraft network packet logging when running with Logback (which bypasses Log4j filter configuration).

Changes:

  • Added a Logback MarkerFilter turbo filter to deny log events marked as NETWORK_PACKETS (configurable via properties).
  • Added the required MarkerFilter import to logback.xml.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@github-actions
Copy link
Copy Markdown

Test Results

 56 files  ±0   56 suites  ±0   4m 20s ⏱️ -22s
571 tests ±0  571 ✅ ±0  0 💤 ±0  0 ❌ ±0 
938 runs  ±0  938 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 44caf1c. ± Comparison against base commit 67b9e0a.

This pull request removes 32 and adds 32 tests. Note that renamed tests count towards both.
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"this":"is","insane":"!","hello":"world"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2026-04-18
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 10:56:57.083606770
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 10:56:57.083737683Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 10:56:57.083757951Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 10:56:57.083792255+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 10:56:57.083821179-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2026-04-18T10:56:57.083968333
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2026-04-18T10:56:57.084108894Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2026-04-18T10:56:57.073936327Z
…
eu.cloudnetservice.driver.impl.document.DocumentSerialisationTest ‑ [4] {"b":1,"s":2,"i":3,"l":4,"f":5.0,"d":6.0,"c":"/","string":"Hello, World!","bol":true,"cloud":["Ben?","Yes","No","HoHoHoHo"],"world":{"hello":"world","this":"is","insane":"!"}}, PRETTY
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [14] 2026-04-27
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [23] 20:39:28.540942590
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [28] 20:39:28.541058227Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [29] 20:39:28.541080008Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [30] 20:39:28.541116116+05:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [31] 20:39:28.541173312-03:00
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [34] 2026-04-27T20:39:28.541313225
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [39] 2026-04-27T20:39:28.541458237Z
eu.cloudnetservice.driver.impl.document.gson.JavaTimeSerializerTest ‑ [4] 2026-04-27T20:39:28.526452662Z
…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: wrapper An issue/pull request releated to the wrapper module code t: fix A pull request introducing a fix for a bug. v: 4.X This pull should be included in the 4.0 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants