Remove zarr error #410
Merged
Remove zarr error #410
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 68.94% 69.03% +0.08%
==========================================
Files 15 15
Lines 1752 1747 -5
==========================================
- Hits 1208 1206 -2
+ Misses 544 541 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kemccusker
approved these changes
May 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like undocumented in zarr 3.0.0 was the removal of the
zarr.errors.GroupNotFoundError. Looking at their PRs, it looks like it will be imminently added back. I think it makes sense for the zarr package to take care of the error throwing so I am removing it from our function.