Skip to content

Conversation

@JMGilbert
Copy link
Contributor

@JMGilbert JMGilbert commented May 13, 2025

This PR builds into dscim the ability to not collapse across batches for the reduced damages, which is a key part of the sectoral SCCs. The PR additionally adds the discount option constant_gwr which creates across-SSP SCCs.

@codecov
Copy link

codecov bot commented May 30, 2025

Codecov Report

Attention: Patch coverage is 57.14286% with 6 lines in your changes missing coverage. Please review.

Project coverage is 68.94%. Comparing base (72bf9e5) to head (901feab).
Report is 136 commits behind head on main.

Files with missing lines Patch % Lines
src/dscim/menu/main_recipe.py 40.00% 3 Missing ⚠️
src/dscim/preprocessing/preprocessing.py 66.66% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #405      +/-   ##
==========================================
+ Coverage   68.91%   68.94%   +0.03%     
==========================================
  Files          15       15              
  Lines        1750     1755       +5     
==========================================
+ Hits         1206     1210       +4     
- Misses        544      545       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JMGilbert JMGilbert requested a review from kemccusker June 11, 2025 19:31
@JMGilbert JMGilbert marked this pull request as ready for review June 11, 2025 19:31
Copy link
Member

@kemccusker kemccusker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, a complete description also gets added to this PR, noting that quantreg was already in the codebase to some extent. Also that this adds a new discounting option.

@JMGilbert JMGilbert changed the title Quantreg sccs quantreg full cloud of points Jun 17, 2025
@kemccusker kemccusker merged commit 8dae2fe into main Jun 21, 2025
3 of 4 checks passed
@kemccusker kemccusker deleted the quantreg_sccs branch June 21, 2025 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants