-
Notifications
You must be signed in to change notification settings - Fork 4
quantreg full cloud of points #405
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #405 +/- ##
==========================================
+ Coverage 68.91% 68.94% +0.03%
==========================================
Files 15 15
Lines 1750 1755 +5
==========================================
+ Hits 1206 1210 +4
- Misses 544 545 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kemccusker
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, a complete description also gets added to this PR, noting that quantreg was already in the codebase to some extent. Also that this adds a new discounting option.
This PR builds into dscim the ability to not collapse across batches for the reduced damages, which is a key part of the sectoral SCCs. The PR additionally adds the discount option
constant_gwrwhich creates across-SSP SCCs.