Open
Conversation
The StreamingMessage component only renders when isStreaming is true. During auto-resume after background tasks complete, session_running was the only signal to enter streaming mode, but its !isStreaming guard caused race conditions where tokens accumulated invisibly. - Add auto_resume_start event broadcast before auto-resume run - Remove !isStreaming guard from session_running handler (idempotent) - Track background watchers for cancellation on stop/shutdown - Touch session during polling to prevent idle sweep killing client - Await auto-resume instead of fire-and-forget create_task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
auto_resume_startWebSocket event broadcast before auto-resume to reliably enter streaming mode!isStreamingguard fromsession_runninghandler (now idempotent)create_taskfor error propagationTest plan