Skip to content

fix: guard cd calls and stash local changes in install.sh#11

Open
SolAstrius wants to merge 1 commit intoClickHouse:mainfrom
SolAstrius:fix/install-sh-safety
Open

fix: guard cd calls and stash local changes in install.sh#11
SolAstrius wants to merge 1 commit intoClickHouse:mainfrom
SolAstrius:fix/install-sh-safety

Conversation

@SolAstrius
Copy link
Copy Markdown
Contributor

Summary

  • Stash local changes before git reset --hard during upgrades, preventing silent data loss
  • Guard all cd calls with || exit 1 to fail fast instead of running commands in the wrong directory

Test plan

  • Fresh install: curl -fsSL .../install.sh | bash completes normally
  • Upgrade with local changes: stash is created and user is informed
  • Upgrade with invalid NERVE_INSTALL_DIR: script exits instead of continuing in wrong dir

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant