Skip to content

Record fixed browser startup markers for Pipecat videos - #1014

Open
zlareb1 wants to merge 1 commit into
mainfrom
fix/pipecat-driver-log-diagnostics
Open

zlareb1 wants to merge 1 commit into
mainfrom
fix/pipecat-driver-log-diagnostics

Conversation

@zlareb1

@zlareb1 zlareb1 commented Nov 20, 2026

Copy link
Copy Markdown
Member

Related: #1011

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry

Not required.

Why

The optional Pipecat recording times out while creating a browser session. Its owned driver is still running, so that observation cannot identify the browser startup failure. The native text check passes and the final owned-child census is empty; no qualified video exists.

Enable the logging-only driver option that routes browser stderr into the existing private log. After owned-process cleanup, inspect one 16 KiB tail through the same held descriptor. Export only fixed marker names for startup, profile, sandbox, crash-handler and DevTools messages. Markers are observations, not root-cause verdicts. Missing or unrecognized messages leave the cause unknown.

Scope and risk

The log remains private and is removed with its temporary directory. The public status contains no raw log text, exception, path, URL, argument, environment value or arbitrary capture. A nonregular, foreign, shared or publicly readable handle refuses observation. A changed size or failed read returns unavailable. The positional read leaves the writer offset unchanged.

Read size and exported data are bounded; log production itself is not byte-bounded. Enabling browser stderr can increase private disk writes. Existing workload limits and cleanup remain in force. The logging option changes the browser logging destination, with sandbox controls, environment filtering, three-second request timeout, native assertions and media limits unchanged. An unsupported driver option remains a failed recording; there is no fallback.

Compatibility, rollout and rollback

  • Wire schema and operator settings: none.
  • Optional recording status adds driver_log_observation.
  • A later recording selects the exact merged main commit. This change does not claim to fix browser startup. Reverting removes the additional private logging and fixed-marker observation.

Tests

Sixteen new diagnostic cases failed before implementation because the observation was absent. The related mocked recorder module now passes all 83 cases in 1.08 seconds. Tests cover fixed markers and private sentinels, bounded tail reads and unchanged offset, unavailable handles, changing size, and observation after cleanup but before closing the log. Native and capture results remain unchanged. These tests start no browser, product service, database or provider.

Scoped Ruff formatting and lint and the diff whitespace check passed. Hosted CI and a fresh independent pushed-head review remain outstanding. The real recording still has no qualified video.

AI assistance in the code (leave one; writing this description with AI is fine):

  • AI-generated: Codex wrote the change. Source inspection covers descriptor ownership, fixed exports, lifecycle ordering and unchanged execution controls. Validation is listed above.

  • I can explain every line of this diff and how it interacts with the rest of Loom.

Checklist

  • Required hosted CI passes.
  • No wire schema, migration, generated SDK, plugin or frontend change.
  • No sandbox, ownership, request timeout or native assertion is weakened.
  • The pushed head and entire final body receive an independent review.
  • Commits are signed off.

Signed-off-by: zlareb1 <lareb.zafar@clickhouse.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant